Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No response on backend (postgresql) crash #135

Closed
strk opened this issue Feb 26, 2014 · 5 comments · Fixed by brianc/node-postgres#543
Closed

No response on backend (postgresql) crash #135

strk opened this issue Feb 26, 2014 · 5 comments · Fixed by brianc/node-postgres#543
Labels
bug
Milestone
1.9.0

Comments

@strk
Copy link

strk commented Feb 26, 2014

I've seen an instance of Windshaft-CartoDB waiting for 10 minutes without luck for an answer from a request while the CartoDB-SQL-API logs reported a backend crash and no long taking response.

I guess there's a bug preventing a response from being completed, but has to be checked.

JIRA REF: https://cartodb.atlassian.net/browse/CDB-1883
@strk strk added this to the 1.8.4 milestone Feb 26, 2014
@strk strk added bug labels Feb 26, 2014
@strk
Copy link
Author

strk commented Mar 14, 2014

I cound easily reproduce with this:

tools/cdbsql 'select count(*) from (select generate_series(1,40000000)) f' &
pg_ctl -m immediate stop

The request never gets a response.

@strk
Copy link
Author

strk commented Mar 14, 2014

Possible reason for this: brianc/node-postgres#534

This was referenced Mar 14, 2014
Closed
Closed
strk pushed a commit to strk/node-postgres that referenced this issue Mar 14, 2014
Remove client from pool on connection end
fb491cf 
Might fix brianc#458
Definitely fixes CartoDB/CartoDB-SQL-API#135
@strk strk mentioned this issue Mar 14, 2014
Closed
@strk
Copy link
Author

strk commented Mar 14, 2014

This patch seems to fix the problem with the hang:
brianc/node-postgres#537

strk pushed a commit that referenced this issue Mar 17, 2014
Add pending test for backend crash (#135)
6d79572
@strk
Copy link
Author

strk commented Mar 17, 2014

Second attempt of a fix: brianc/node-postgres#542

@strk
Copy link
Author

strk commented Mar 17, 2014

Alright the second pull only partially fixes the issue. it fixes the error from first query, but does not remove the connection from the pool which as a consequence remains sticky.
The first pool is trying to deal with that.

strk pushed a commit to CartoDB/node-postgres that referenced this issue Mar 17, 2014
Remove disconnected clients from the pool
9c5cd8d 
Might fix brianc#458
Fixes CartoDB/CartoDB-SQL-API#135
@strk strk mentioned this issue Mar 17, 2014
Merged
strk pushed a commit to CartoDB/node-postgres that referenced this issue Mar 18, 2014
Remove disconnected clients from the pool
7e2e87d 
Might fix brianc#458
Fixes CartoDB/CartoDB-SQL-API#135
Avoids loop between pool.destroy and client.end
strk pushed a commit to CartoDB/node-postgres that referenced this issue Mar 18, 2014
Remove disconnected clients from the pool
edba02c 
Might fix brianc#458
Fixes CartoDB/CartoDB-SQL-API#135
Avoids loop between pool.destroy and client.end
@strk strk closed this as completed in f88d33f Mar 19, 2014
@strk strk modified the milestones: 1.9.0, 1.8.4 Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.9.0
1 participant
@strk