Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incongruous error message from the command-line parsing network parameters. #242

Closed
eMCeee89 opened this issue Jul 29, 2022 · 1 comment
Closed
Labels
bug Something isn't working help welcomed Good for newcomers server Issues which regard the server

Comments

@eMCeee89
Copy link

Hello,
I have a question regarding this error message: https://github.com/CardanoSolutions/ogmios/blob/master/server/src/Ogmios/Options.hs#L288-L290

Is it really like this, that parameters networkMagic, systemStart and/or epochLength might be missing? In a block above, epochLength is not parsed: https://github.com/CardanoSolutions/ogmios/blob/master/server/src/Ogmios/Options.hs#L280-L283
Instead, protocolConsts.k is parsed from byronGenesis hence the error message can be confusing.

Could you please check this one? I have a problem to start an Ogmios container using my own private testnet and I crossed this error message yet an output printed below the error message with all defined parameters contains all allegedly required network parameters (networkMagic, systemStart and/or epochLength) hence it is confusing what is really required.

Thank you in advance.

@KtorZ
Copy link
Member

KtorZ commented Jul 29, 2022

Ho, good catch! I used to pull the epochLength from the Shelley genesis but that ended up not being needed and replaced with the security parameter (k) from the Byron genesis; the error message is an artifact from the past and is indeed now confusing; also because the error shows only the Shelley genesis but pulls things from the Byron genesis as well (this k parameter).

Folding everything into a Maybe also makes it a little harder to know which one of the three parameter is actually causing an issue; so it could definitely be improved here.

@KtorZ KtorZ added bug Something isn't working server Issues which regard the server help welcomed Good for newcomers labels Jul 29, 2022
@KtorZ KtorZ changed the title Error message explanation Incongruous error message from the command-line parsing network parameters. Jul 31, 2022
@KtorZ KtorZ closed this as completed in 29a7334 Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help welcomed Good for newcomers server Issues which regard the server
Projects
None yet
Development

No branches or pull requests

2 participants