Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Use min_commission_rate Instead of ValidatorCommissionDecorator #124

Open
dongsam opened this issue Mar 25, 2024 · 0 comments

Comments

@dongsam
Copy link
Collaborator

dongsam commented Mar 25, 2024

Background:

  • The latest version of the SDK's staking module params includes min_commission_rate.
  • Both the existing ValidatorCommissionDecorator of antehandler logic and the newly introduced min_commission_rate in the SDK staking module params perform the same function: they validate the minimum commission rate during the Create and Edit validator processes. Ref1, Ref2.

Suggestions:

  • antehandler adds complexity due to nested msg processing like authz, performing unnecessary validations on all transactions. Simplifying this process is recommended.
  • Without specific reasons against it, using min_commission_rate is advised for its simplicity and manageability. Moreover, as this parameter is governed not hardcoded, it can be easily modified through governance proposals in the future.

Action Items:
If the decision is made to use min_commission_rate instead of antehandler:

  1. Remove ValidatorCommissionDecorator from the antehandler.
  2. Set the initial value of min_commission_rate in the upgrade handler.

This will be incorporated in the ongoing SDK v50 bump PR b-harvest#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant