Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference field to YAML input files #15

Closed
ischoegl opened this issue Dec 17, 2019 · 2 comments
Closed

Add reference field to YAML input files #15

ischoegl opened this issue Dec 17, 2019 · 2 comments
Labels
feature-request New feature request

Comments

@ischoegl
Copy link
Member

ischoegl commented Dec 17, 2019

Abstract

A reference field would clarify the provenance of YAML files beyond what is included in the decription field, which is automatically generated from chemkin input (but is missing for many YAML files in 2.5.0a3). An implementation could use a single BibTeX entry as input, which is reformatted into YAML, e.g.

reference:
  - title: GRI-Mech 3.0
  - author: [G. P. Smith, D. M. Golden, M. Frenklach, N. W. Moriarty, B. Eiteneer, M. Goldenberg, C. T. Bowman, R. K. Hanson, S. Song, W. C. Gardiner, Jr., V. V. Lissianski, Z. Qin]
  - year: 1999
  - howpublished: http://www.me.berkeley.edu/gri_mech/

Motivation

While some input files (e.g. gri30.yaml) do use the description tag, others do not (e.g. nDodecane_Reitz.yaml, h2o2.yaml, nasa.yaml, gri30_highT.yaml). In many cases, it is not clear where input originates (i.e. are they peer-reviewed? is this just a file compiled for demonstration purposes?)

If available, a chemkin header block does not use consistent content. Content pulled from a BibTeX entry would resolve this shortcoming.

Describe the need for the proposed change:

This feature request proposes a mechanism to address Cantera/cantera#339; further: the BibTeX comment field can be used to add context.

Possible Solutions

The proposed solution would be to generate information from a single BibTeX entry, which is passed as an input file via a --bibtex= option to ck2yaml. The BibTeX fields can be converted to yaml fields with little effort.

References

@ischoegl ischoegl added the feature-request New feature request label Dec 17, 2019
@bryanwweber
Copy link
Member

I think this would probably be a good idea. Fortunately, I don't think anything has to change within Cantera to enable this, the field just has to be added to the relevant files (other than adding the ck2yaml interface).

A note from our experience with PyKED... Sometimes (most times?) a single reference isn't sufficient, so we need a way for this to be able to handle that case.

@ischoegl
Copy link
Member Author

Sometimes (most times?) a single reference isn't sufficient

Thanks for this feedback; it is easily addressed (e.g. use BibTeX’s citation labels for each entry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants