Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixtureFugacityTP::solveCubic finds wrong root on mingw #1157

Open
ischoegl opened this issue Dec 9, 2021 · 0 comments
Open

MixtureFugacityTP::solveCubic finds wrong root on mingw #1157

ischoegl opened this issue Dec 9, 2021 · 0 comments
Labels

Comments

@ischoegl
Copy link
Member

ischoegl commented Dec 9, 2021

Problem description

Within the test suite, TEST_F(cubicSolver_Test, solve_cubic) fails on mingw, as discussed on #1144. For mingw, the check for

EXPECT_NEAR(nSolnValues, -2, 1.e-6);

fails, where +2 is returned instead. At the moment, the test is disabled (ensuring that the newly introduced mingw GH runner succeeds).

Additional context

The PengRobinson and RedlichKwong models both use this value and do not treat the positive and negative return values equally.

Issue goes back to #1047

An associated test is disabled for mingw:

#ifdef __MINGW32__
TEST_F(cubicSolver_Test, solve_cubic_DISABLED)
{
// the following test fails on mingw: EXPECT_NEAR(nSolnValues, -2, 1.e-6);
// where the positive root is found instead
}
#else
TEST_F(cubicSolver_Test, solve_cubic)
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

1 participant