From 2ac1ebe0eb958f4993a18981dd27d30752c74155 Mon Sep 17 00:00:00 2001 From: Craig Roy Date: Wed, 8 May 2024 12:17:13 +0100 Subject: [PATCH] test: Fix unconnected ports in extension test (#1010) While trying to separate out extension validation from the rest of validation, I found that the graph here was invalid! The extension error gets thrown before it starts complaining about all of the unconnected outputs. --- hugr/src/hugr/validate/test.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hugr/src/hugr/validate/test.rs b/hugr/src/hugr/validate/test.rs index 8cfec91c4..a1518fcb2 100644 --- a/hugr/src/hugr/validate/test.rs +++ b/hugr/src/hugr/validate/test.rs @@ -916,19 +916,21 @@ mod extension_tests { let all_rs = ExtensionSet::from_iter([XA, XB]); - let main_sig = FunctionType::new(type_row![], type_row![NAT]) + let main_sig = FunctionType::new(type_row![NAT], type_row![NAT]) .with_extension_delta(all_rs.clone()) .into(); let mut main = module_builder.define_function("main", main_sig)?; + let [inp_wire] = main.input_wires_arr(); + let [left_wire] = main .dfg_builder( FunctionType::new(type_row![], type_row![NAT]), Some(XA.into()), [], )? - .finish_with_outputs([])? + .finish_with_outputs([inp_wire])? .outputs_arr(); let [right_wire] = main @@ -937,7 +939,7 @@ mod extension_tests { Some(XB.into()), [], )? - .finish_with_outputs([])? + .finish_with_outputs([inp_wire])? .outputs_arr(); let builder = main.dfg_builder( @@ -945,8 +947,8 @@ mod extension_tests { Some(all_rs), [left_wire, right_wire], )?; - let [_left, _right] = builder.input_wires_arr(); - let [output] = builder.finish_with_outputs([])?.outputs_arr(); + let [left, _] = builder.input_wires_arr(); + let [output] = builder.finish_with_outputs([left])?.outputs_arr(); main.finish_with_outputs([output])?; let handle = module_builder.hugr().validate(&PRELUDE_REGISTRY);