Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer link enum definitions. #865

Closed
bhollis opened this issue Jan 30, 2019 · 2 comments
Closed

Can no longer link enum definitions. #865

bhollis opened this issue Jan 30, 2019 · 2 comments

Comments

@bhollis
Copy link

bhollis commented Jan 30, 2019

In the latest update of openapi-2.json, all of the enum references were removed. I suspect this was part of #148 (which I hadn't seen the discussion for), but there's no corresponding x-enum-reference in the document, so I can no longer link those fields to their definitions. This greatly reduces the ability of my bungie-api-ts generator (used in DIM) to build good types from the API docs.

@vthornheart-bng
Copy link
Contributor

Ah, good call - I'd fixed the open API 3.0 spec, but not the 2.0 spec. I'll see about getting x-enum-reference as an extension property in 2.0 as well.

@vthornheart-bng
Copy link
Contributor

That one's easy enough to fix and has a separate deployment from the normal builds, so I went ahead and changed it up. I should have new specs posted shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants