Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unified profile-level Records #758

Open
joshhunt opened this issue Nov 5, 2018 · 1 comment
Open

Provide unified profile-level Records #758

joshhunt opened this issue Nov 5, 2018 · 1 comment

Comments

@joshhunt
Copy link

joshhunt commented Nov 5, 2018

While the data for Records exist at both the Profile and Character level, I believe users expect Triumphs to operate profile-wide, so building out something that operates similarly to the in-game Triumphs viewer is trickier than it needs to be IMHO because of how you need to merge in character records with profile records. I'm always anxious that when I do this I'm merging incorrectly, or a character with that triumph not completed overrides a character that has completed it.

Could the ProfileRecords summarise the character-level records, similar to how its done in game?

@vthornheart-bng
Copy link
Contributor

Indeed, this is something I struggled with philosophically while making the system. The fears I have is that there's actually no hard-set restriction keeping Triumphs from being character-specific: and indeed, some portions of the Triumphs state even now is character-specific (such as visibility IIRC).

Many times, when I assume that something's going to be kept at a certain scope in the game and there's not a hard-coded restriction keeping someone from changing it, it gets changed and causes us to have to pivot in unexpected ways. It was that paranoia that made me make the Triumphs as they are currently... but I'll give it some thought, I may have been overly paranoid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants