Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict parsing of from_json in LolInfo/FortniteInfo #146

Open
ecly opened this issue Jul 7, 2019 · 0 comments
Open

Strict parsing of from_json in LolInfo/FortniteInfo #146

ecly opened this issue Jul 7, 2019 · 0 comments

Comments

@ecly
Copy link
Member

ecly commented Jul 7, 2019

For some data for the structs, we're simply mapping and converting from string based maps to atom based maps.
As a result, we could theoretically store arbitrary amounts of data in these maps, as we are not discarding anything we don't need.
We may want to make this stricter by only retrieving and storing the data that we know we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant