style: standardized error messages

BranchMetrics · Mar 2, 2017 · fb9b864 · fb9b864
1 parent f21736b
commit fb9b864
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/hooks/afterPrepare.js b/hooks/afterPrepare.js
@@ -26,7 +26,7 @@
         iosPlist.addBranchSettings(preferences)
         iosCapabilities.enableAssociatedDomains(preferences)
         iosAssociatedDomains.addAssociatedDomains(preferences)
-        iosDevelopmentTeam.addDevelopmentTeam(preferences) // does not work, still needs to run through Xcode
+        iosDevelopmentTeam.addDevelopmentTeam(preferences)
       }
     })
   }

diff --git a/hooks/lib/android/androidManifest.js b/hooks/lib/android/androidManifest.js
@@ -178,7 +178,7 @@
     } else if (preferences.linkDomain.indexOf('bnc.lt') !== -1) {
       // bnc.lt
       if (preferences.androidPrefix == null) {
-        throw new Error('Branch SDK plugin is missing "android-prefix" in <branch-config> in your config.xml')
+        throw new Error('BRANCH SDK: Missing "android-prefix" in <branch-config> in your config.xml. https://goo.gl/GijGKP')
       }
 
       intentFilterData.push(getAppLinkIntentFilterDictionary(preferences.linkDomain, preferences.androidPrefix))

diff --git a/hooks/lib/ios/developmentTeam.js b/hooks/lib/ios/developmentTeam.js
@@ -34,7 +34,7 @@
       // pretty-json
       return JSON.stringify(content, null, 2)
     } catch (err) {
-      throw new Error('Branch SDK cannot write build.json within your root directory.')
+      throw new Error('BRANCH SDK: Cannot write build.json within your root directory. https://goo.gl/GijGKP')
     }
   }
 
@@ -44,7 +44,7 @@
     try {
       return JSON.parse(content)
     } catch (err) {
-      throw new Error('Branch SDK cannot read build.json within your root directory.')
+      throw new Error('BRANCH SDK: Cannot read build.json within your root directory. https://goo.gl/GijGKP')
     }
   }
 

diff --git a/hooks/lib/npm/nodeDependencies.js b/hooks/lib/npm/nodeDependencies.js
@@ -30,7 +30,7 @@
     installNodeModules(modules, function (err) {
       if (err) {
         // handle error
-        throw new Error('BRANCH SDK: Failed to install the Branch SDK')
+        throw new Error('BRANCH SDK: Failed to install the Branch SDK. https://goo.gl/GijGKP')
       } else {
         // only run once
         setPackageInstalled(installFlagLocation)
@@ -59,7 +59,7 @@
       // handle error
       if (err) {
         callback(true)
-        throw new Error('BRANCH SDK: Failed to install Branch Dependency: "' + module + '"')
+        throw new Error('BRANCH SDK: Failed to install Branch node dependency ' + module + '. https://goo.gl/GijGKP')
       } else {
         // next module
         installNodeModules(modules, callback)

diff --git a/hooks/lib/sdk/configXml.js b/hooks/lib/sdk/configXml.js
@@ -27,7 +27,7 @@
     var configXml = xmlHelper.readXmlAsJson(pathToConfigXml)
 
     if (configXml == null) {
-      throw new Error('config.xml not found! Please, check that it exist in your project\'s root directory.')
+      throw new Error('BRANCH SDK: A config.xml is not found in project\'s root directory. https://goo.gl/GijGKP')
     }
 
     return configXml
@@ -38,7 +38,7 @@
     var branchConfig = configXml.widget['branch-config']
 
     if (branchConfig == null || branchConfig.length === 0) {
-      throw new Error('<branch-config> tag is not set in the config.xml. The Branch SDK is not properly installed.')
+      throw new Error('BRANCH SDK: <branch-config> tag is not set in the config.xml. https://goo.gl/GijGKP')
     }
 
     return branchConfig[0]
@@ -89,22 +89,22 @@
   // validate <branch-config> properties within config.xml
   function validateBranchPreferences (preferences) {
     if (preferences.bundleId === null) {
-      throw new Error('Branch SDK plugin is missing "widget id" in your config.xml')
+      throw new Error('BRANCH SDK: Missing "widget id" in your config.xml. https://goo.gl/GijGKP')
     }
     if (preferences.bundleName === null) {
-      throw new Error('Branch SDK plugin is missing "name" in your config.xml')
+      throw new Error('BRANCH SDK: Missing "name" in your config.xml. https://goo.gl/GijGKP')
     }
     if (preferences.branchKey === null) {
-      throw new Error('Branch SDK plugin is missing "branch-key" in <branch-config> in your config.xml')
+      throw new Error('BRANCH SDK: Missing "branch-key" in <branch-config> in your config.xml. https://goo.gl/GijGKP')
     }
     if (preferences.uriScheme === null) {
-      throw new Error('Branch SDK plugin is missing "uri-scheme" in <branch-config> in your config.xml')
+      throw new Error('BRANCH SDK: Missing "uri-scheme" in <branch-config> in your config.xml. https://goo.gl/GijGKP')
     }
     if (preferences.linkDomain === null) {
-      throw new Error('Branch SDK plugin is missing "uri-scheme" in <branch-config> in your config.xml')
+      throw new Error('BRANCH SDK: Missing "uri-scheme" in <branch-config> in your config.xml. https://goo.gl/GijGKP')
     }
     if (preferences.iosTeamProd === null) {
-      throw new Error('Branch SDK plugin is missing "ios-team-prod" in <branch-config> in your config.xml')
+      throw new Error('BRANCH SDK: Missing "ios-team-prod" in <branch-config> in your config.xml. https://goo.gl/GijGKP')
     }
   }
 })()