Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra edge for a t-shape #21

Open
vvoovv opened this issue Sep 7, 2020 · 5 comments
Open

Extra edge for a t-shape #21

vvoovv opened this issue Sep 7, 2020 · 5 comments

Comments

@vvoovv
Copy link

vvoovv commented Sep 7, 2020

demo.py t-shape_extra_edge.txt
image

@vvoovv
Copy link
Author

vvoovv commented Sep 7, 2020

Also for a polygon with a hole:
demo.py t-shape_hole_extra_edge.txt
image

@Botffy
Copy link
Owner

Botffy commented Oct 11, 2020

This is still extant. I'm not sure if this can be solved without introducing the "multi-events" (see #16 )

Many thanks for the reports and the example files, by the way!

@vvoovv
Copy link
Author

vvoovv commented Oct 12, 2020

We are trying to solve that through postprocessing of the skeleton in our port of the library:
prochitecture/bpypolyskel#5 (comment)

@Botffy
Copy link
Owner

Botffy commented Oct 12, 2020

Wow, that picture of those buildings is pretty awesome, I love it!

I'll link to your port in the Readme :)

As for the erroneous edge in the T-shaped polygon: I don't actually think it's an extra edge, I'm pretty sure it should be there, except it should be horizontal. I understand this isn't ideal for your application, but it must be there, otherwise it wouldn't be a tree. Yeah, it can be eliminated in postprocessing, I guess, though the underlying problem bothers me anyhow.

@vvoovv
Copy link
Author

vvoovv commented Oct 12, 2020

I'll link to your port in the Readme :)

That would be nice. Here is the description of our port:

A port of Botffy/polyskel library for Blender that outputs polygons formed by a straight skeleton. 'pip install mathutils' to use it as a general purpose library independent of Blender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants