Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add a KineticModel method to handle cycle and diagram plotting #48

Open
nawtrey opened this issue Dec 8, 2021 · 2 comments
Open
Labels
API API-related changes

Comments

@nawtrey
Copy link
Collaborator

nawtrey commented Dec 8, 2021

As discussed in 3. of this comment, the structures of plotting.draw_diagrams() and plotting.draw_cycles() are very similar. It shouldn't be terribly difficult to combine these into a single plotting function that can handle both kinds of figures. This is probably best handled after the completion of #47.

@nawtrey
Copy link
Collaborator Author

nawtrey commented Dec 20, 2021

One thing that would help with this is to add a parameter**params to _plot_single_diagram() instead of manually specifying every single input parameter we want to use since a host of them are only used for inputting directly into NetworkX plotting functions. It would also simplify the documentation substantially, which would make things much more concise. This should probably be handled first, and detailed in a separate issue.

@nawtrey nawtrey added API API-related changes and removed maintenance labels Aug 4, 2024
@nawtrey nawtrey changed the title MAINT: Write a general plotting function to handle cycle and diagram plotting API: Add a KineticModel method to handle cycle and diagram plotting Aug 8, 2024
@nawtrey
Copy link
Collaborator Author

nawtrey commented Aug 8, 2024

With GH-83 merged, I think this can be refocused on adding a method to the new class object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related changes
Projects
None yet
Development

No branches or pull requests

1 participant