Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated constant MT_RAND_PHP in tests #176

Open
ryanhblack opened this issue Mar 22, 2024 · 2 comments
Open

Use of deprecated constant MT_RAND_PHP in tests #176

ryanhblack opened this issue Mar 22, 2024 · 2 comments

Comments

@ryanhblack
Copy link

Related to Issue #23. According to the PHP documentation for mt_srand(), the MT_RAND_PHP mode uses an incorrect Mersenne Twister implementation, and it is now deprecated as of PHP 8.3.0.

The correct Mersenne Twister implementation caused the tests using it to fail, so past developers chose to use the old implementation to resolve issue #23. A better fix would be to have the tests expect the correct implementation so the deprecated constant can be removed.

The issue is mitigated by the fact that the deprecated constant is only used in tests (BaconQrCodeTest\Common\BitArrayTest and BaconQrCodeTest\Common\ReedSolomonCodecTest).

@DASPRiD
Copy link
Member

DASPRiD commented Mar 22, 2024

Would you like to supply a PR?

@ryanhblack
Copy link
Author

I can, but it won't be high priority for me, so it might take some time to update the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants