Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit conversion from float to int #131

Open
varik-kos opened this issue Apr 17, 2023 · 3 comments
Open

Implicit conversion from float to int #131

varik-kos opened this issue Apr 17, 2023 · 3 comments
Labels
bug help wanted

Comments

@varik-kos
Copy link 

src\BaconQrCode\Encoder\MaskUtil.php



Implicit conversion from float 19.666666666666668 to int loses precision in vendor\bacon\bacon-qr-code\src\BaconQrCode\Encoder\MaskUtil.php:223

add rounding

php 8.1
@DASPRiD
Copy link
Member

DASPRiD commented Apr 17, 2023

Which version are you on?

@wajdijurry
Copy link

+1
I am using v1.0.2

@DASPRiD
Copy link
Member

DASPRiD commented Jun 2, 2024

+1 I am using v1.0.2

That version is EOL for a long time, current version is 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DASPRiD @wajdijurry @varik-kos