Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Region auto enable on env variable #7328

Open
bgavrilMS opened this issue Sep 20, 2024 · 0 comments
Open

[Feature Request] Region auto enable on env variable #7328

bgavrilMS opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
confidential-client Issues regarding ConfidentialClientApplications feature Feature requests. msal-node Related to msal-node package

Comments

@bgavrilMS
Copy link
Member

Region auto-enable

  1. On creation of a ConfidentialClientApplication, MSAL shall detect env variable MSAL_FORCE_REGION, which will be set to a specific region (e.g. westus1)
  2. If this env variable is set, MSAL shall opt-in to ESTS-R with the value of this variable.

Disabling the behavior

If region is explicitly set in MSAL to the string "DisableMsalForceRegion`, then the above no longer applies

Conflicts with WithAzureRegion(xyz)

Use of the api WithRegion(xyz) takes precedence over the env variable.

Acceptance tests

For all of the tests, assume env variable MSAL_FORCE_REGION=eastus

  1. No other config is used. ACTUAL region used: eastus
  2. App developer configures region "westus" in MSAL. ACTUAL region used: westus
  3. App developer configures region "DisableMsalForceRegion" in MSAL. ACTUAL region used: none

Original issue:

AzureAD/microsoft-authentication-library-for-dotnet#4930

@bgavrilMS bgavrilMS added the confidential-client Issues regarding ConfidentialClientApplications label Sep 20, 2024
@github-actions github-actions bot added the more-information-needed Use this label when you are waiting on information from the issue creator label Sep 20, 2024
@bgavrilMS bgavrilMS added feature Feature requests. msal-node Related to msal-node package and removed more-information-needed Use this label when you are waiting on information from the issue creator labels Sep 20, 2024
@bgavrilMS bgavrilMS reopened this Sep 20, 2024
@AzureAD AzureAD deleted a comment from github-actions bot Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confidential-client Issues regarding ConfidentialClientApplications feature Feature requests. msal-node Related to msal-node package
Projects
None yet
Development

No branches or pull requests

2 participants