Use gnmi container to support configuration and telemetry #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Oct 27, 2023
| @@ -92,7 +92,7 @@ sonic-restapi will be replaced by gNMI interface in the future. | |||
|
|
|||
| sonic-telemetry provides gNMI/gNOI server interface. And sonic-telemetry provides only telemetry via gRPC, and the gap is configuration. | |||
|
|
|||
| We will update sonic-telemetry to support configuration. | |||
| We will change the name of sonic-telemetry to sonic-gnmi, as it better reflects the functionality of the service. The gnmi container will handle both configuration and telemetry tasks, simplifying the deployment and management of the system. | |||
There was a problem hiding this comment.
I do not see detailed explanation of current situation (one telemetry), one container future usage, two containers future usage. Could you make them explicit for readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Lv ganglv@microsoft.com
What is the motivation for this PR?
Now SONiC uses telemetry container to support configuration and telemetry in master branch.
We propose to use gnmi container to support configuration and telemetry, and we will disable telemetry container by default.
PR: