Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZTP] Use config db instead of ZTP configuration profile while dhcp d… #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peter-yu
Copy link
Contributor

@peter-yu peter-yu commented May 2, 2024

[ZTP] Use config db instead of ZTP configuration profile while dhcp discovery

By adding USE_DEFAULT_CONFIG="no" in /etc/default/ztp for Inband ZTP, it won't generate /tmp/ztp_config_db.json, but use current redis config db during dhcp discovery.

This solves the interface breakout config reset to default mode (or other config, ex: FEC mode) and operation down issue.

…iscovery

By adding USE_DEFAULT_CONFIG="no" in /etc/default/ztp, it won't generate
/tmp/ztp_config_db.json, but using current redis config db during dhcp
discovery.

This solves the interface breakout config reset to default mode and oper down issue.
@peter-yu peter-yu marked this pull request as draft May 2, 2024 02:15
@peter-yu peter-yu marked this pull request as ready for review May 2, 2024 09:55
@peter-yu
Copy link
Contributor Author

peter-yu commented May 8, 2024

@rajendra-dendukuri Can you help to review this PR? Thanks.

@rajendra-dendukuri
Copy link
Collaborator

Can you please elaborate on how these changes are used. In principle, I am OK with the changes but would like to understand the motivation and the use case.

@peter-yu
Copy link
Contributor Author

peter-yu commented May 15, 2024

There is a case that the inband port speed of DUT is 400G. As for the peer device, which connected to DUT, is with port speed of 100G. It requires to config port breakout on DUT and the fec (Forward Error Correction) mode in order to let the link up (same port speed, same fec mode with peer device). ex: breakout 400G to 100G, and fec=rs.
During inband ZTP process, these port attributes on DUT will be reset to factory default value, thus the link is down.

The PR would like to use the port configuration in config_db.json while DHCP discoveryprocess, thus it promise the link configuration correctness and let the link up.

This is enabled by adding USE_DEFAULT_CONFIG="no" in /etc/default/ztp for Inband ZTP.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants