Add support for port mirroring CLIs #936

rupesh-k · 2020-06-04T19:41:30Z

Signed-off-by: Rupesh Kumar rupesh-k.kumar@broadcom.com

- What I did

Port mirroring CLI implementation
HLD @ sonic-net/SONiC#58

- How I did it
Enhance existing mirror_session command to support port mirroring.

- How to verify it
Create ERSPAN/SPAN mirror session and verify show mirror_session.

- Previous command output (if the output of a command-line utility has changed)

config mirror_session add everflow0 10.1.1.1 12.1.1.1 10 10
root@sonic:/home/admin# show mirror_session
Name Status SRC IP DST IP GRE DSCP TTL Queue Policer Monitor Port SRC Port Direction

everflow0 active 10.1.1.1 12.1.1.1 10 10

- New command output (if the output of a command-line utility has changed)

config mirror_session add span sess1 Ethernet44 Ethernet40 rx

root@sonic:/home/admin# show mirror_session
ERSPAN Sessions
Name Status SRC IP DST IP GRE DSCP TTL Queue Policer Monitor Port SRC Port Direction

everflow0 active 10.1.1.1 12.1.1.1 0 10 10

SPAN Sessions
Name Status DST Port SRC Port Direction Queue Policer

sess1 active Ethernet44 Ethernet40 rx

Signed-off-by: Rupesh Kumar <rupesh-k.kumar@broadcom.com>

rupesh-k · 2020-06-24T06:11:28Z

Thanks @prsunny for adding reviewers to swss port-mirroring PR.
Can u please help here also.

rupesh-k · 2020-06-25T02:39:24Z

Thanks @prsunny

Hi @daall ,

Can u please help with review, I hope we can make this feature for 202006 release :)

Thanks

kperumalbfn · 2020-06-25T14:28:46Z

doc/Command-Reference.md

+While adding a new SPAN session, users need to configure the following fields that are used while forwarding the mirrored packets.
+1) destination port,
+2) optional - List of source ports- List of source ports which can have both Ethernet and LAG ports.
+3) optional - Direction - Mirror session direction when configured along with Source port.


Could you specify the default direction as this is optional?

When source port is specified, we can make direction default as both. Let me push that change.

Done. taken care of this. Thanks.

kperumalbfn · 2020-06-25T14:30:33Z

doc/Command-Reference.md

+
+While adding a new SPAN session, users need to configure the following fields that are used while forwarding the mirrored packets.
+1) destination port,
+2) optional - List of source ports- List of source ports which can have both Ethernet and LAG ports.


Can we add a note that atleast one port/LAG is required for local span?

we can have local span session with only destination port, which can be used in ACL mirroring.
Direction is optional in this case. Based on ingress/egress ACL, the corresponding flow gets mirrored.

config/main.py

…n config

daall

See comments.

acl_loader/main.py

config/main.py

daall · 2020-06-25T23:10:14Z

config/main.py

+        if validate_mirror_session_config(config_db, session_name, None, src_port, direction) is False:
+            return
+        config_db.set_entry("MIRROR_SESSION", session_name, session_info)
+    else:


@abdosi could you take a quick look at the multi-NPU logic here and make sure it looks OK to you?

Validation need to be updated so that src_port and dst_port are in same asic/namespace.
TO_DO item (not blocking for this PR)

Ok. will take of this in next PR. How do I validate this ?

config/main.py

doc/Command-Reference.md

rupesh-k · 2020-06-26T00:17:04Z

Thanks alot @daall .

dev-aviz · 2020-06-26T15:21:09Z

config/main.py

+            click.echo("Error: Destination Interface {} is invalid".format(dst_port))
+            return False
+
+        if interface_is_in_vlan(vlan_member_table, dst_port):


If the port is a routed port, SPAN session is supported?

No. Not supported. Please check in latest patchset.

dev-aviz · 2020-06-26T15:22:08Z

config/main.py

+            click.echo("Error: Destination Interface {} has vlan config".format(dst_port))
+            return False
+
+        if interface_has_mirror_config(mirror_table, dst_port):


Not sure if I understand this correctly, can a single dst port cannot be a monitor (mirror-to) port
for multiple mirror sessions?
For example
case 1: mirror rx from Ethernet0 to Etherent4
case 2: mirror rx&tx from Ethernet2 to Etherent4
with the above check, case 2 will fail?

Yes. This is not supported. We allow only one mirror session per port, The session can have any number of ports.

dev-aviz · 2020-06-26T15:23:38Z

config/main.py

+        session_info['direction'] = direction.upper()
+
+    if policer is not None:
+        session_info['policer'] = policer


What is the need for policer and queue for SPAN sessions?

This is existing support in community. This is to police the mirrored traffic.

dev-aviz · 2020-06-26T15:37:58Z

acl_loader/main.py


-        print(tabulate.tabulate(data, headers=header, tablefmt="simple", missingval=""))
+            if val.get("type") == "SPAN":


What is the need for policer and queue for SPAN sessions?

same as above. Extending it to SPAN also.

rupesh-k · 2020-06-29T17:08:24Z

Thanks @daall for the review. I have taken care of the comments. Can you please review again.

acl_loader/main.py

config/main.py

daall

Looking a lot better! Found a couple more things, there are also a few from last time that got missed. You might have to click the "Load more..." button in the PR to see all of them. :)

config/main.py

rupesh-k · 2020-06-29T18:26:50Z

Looking a lot better! Found a couple more things, there are also a few from last time that got missed. You might have to click the "Load more..." button in the PR to see all of them. :)

Yes. sorry. :) i figured once u started first comment, will push in some time now. Thanks for quickly checking.

rupesh-k · 2020-06-30T18:08:49Z

Thanks @daall . I have resolved all comments. Can u please review.

amin-alavi · 2020-06-30T18:13:18Z

@daall @kperumalbfn @dev-aviz , Just like the request in the related PR, and given the imminent cutting of 202006 branch, can this PR be merged and any further updates to be made in 202006 branch?

Thanks!

rupesh-k · 2020-06-30T19:27:36Z

@daall found some other places where it can be fixed for simpler validation. Modified and pushed. :) thanks

amin-alavi · 2020-06-30T19:42:20Z

@abdosi , missed to add you to my request to review and approve.

abdosi · 2020-07-01T00:30:30Z

doc/Command-Reference.md

+
+- Usage:
+  ```
+  config mirror_session span add <session_name> <dst_port> [source-port-list] [direction] [queue] [policer <policer_name>]


this need to be enhance for Multi-asic platforms. dst port need to be on same asic where mirror session binded.
we need to enhance to take option -n and all dest port should be on same ASIC/namespace

We have enhanced similar for other features and PR# #878 with details

This can be TO_DO item and need not be needed with this PR

@rlhui

Ok. thanks for sharing PR. will take care in next PR. please suggest on how can we validate these.

abdosi · 2020-07-01T00:31:50Z

config/main.py

+        for front_asic_namespaces in namespaces['front_ns']:
+            per_npu_configdb[front_asic_namespaces] = ConfigDBConnector(use_unix_socket_path=True, namespace=front_asic_namespaces)
+            per_npu_configdb[front_asic_namespaces].connect()
+            if validate_mirror_session_config(per_npu_configdb[front_asic_namespaces], session_name, dst_port, src_port, direction) is False:


Validation need to be updated so that src_port and dst_port are in same asic/namespace.
TO_DO item (not blocking for this PR)

daall · 2020-07-01T00:32:58Z

retest this please

abdosi · 2020-07-01T00:43:05Z

doc/Command-Reference.md

+This command supports configuring both SPAN/ERSPAN sessions.
+In SPAN user can configure mirroring of list of source ports/LAG to destination port in ingress/egress/both directions.
+In ERSPAN user can configure mirroring of list of source ports/LAG to a destination IP.
+Both SPAN/ERSPAN support ACL based mirroring and can be used in ACL configurations.


can we have Everflow ACL table with everflow mirror session and Data ACL Table with port based mirror session ?

abdosi · 2020-07-01T00:49:56Z

doc/Command-Reference.md

+
+- Usage:
+  ```
+  config mirror_session span add <session_name> <dst_port> [source-port-list] [direction] [queue] [policer <policer_name>]


Does it uses ACL internally ? Can we specify queue and policer without using ACL ? Also if does not use ACL internally can we police with direction as tx ?

Have we verified this combination and what is the behaviour at Sonic level if SAI return error for any of unsupported combination

* Add support for port mirroring CLIs Signed-off-by: Rupesh Kumar <rupesh-k.kumar@broadcom.com>

rupesh-k added 2 commits June 4, 2020 11:20

Add support for port mirroring CLIs

f66a8cc

Signed-off-by: Rupesh Kumar <rupesh-k.kumar@broadcom.com>

Updated Command Reference Guide with config and examples

c2dab24

rupesh-k mentioned this pull request Jun 16, 2020

SONiC Port mirroring HLD sonic-net/SONiC#580

Merged

prsunny requested a review from daall June 24, 2020 15:04

kperumalbfn reviewed Jun 25, 2020

View reviewed changes

Set default direction as both when source port is specified in sessio…

47f4a93

…n config

kperumalbfn previously approved these changes Jun 25, 2020

View reviewed changes

daall suggested changes Jun 25, 2020

View reviewed changes

daall requested a review from abdosi June 25, 2020 23:15

dev-aviz reviewed Jun 26, 2020

View reviewed changes

Addressed review comments

cd23175

rupesh-k dismissed kperumalbfn’s stale review via cd23175 June 29, 2020 13:47

rupesh-k requested a review from daall June 29, 2020 17:08

daall reviewed Jun 29, 2020

View reviewed changes

acl_loader/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

daall suggested changes Jun 29, 2020

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

amin-alavi mentioned this pull request Jun 30, 2020

[mirrororch] Port Mirroring implementation sonic-net/sonic-swss#1314

Merged

rupesh-k added 2 commits June 30, 2020 10:56

Addressed review comments

9588c94

Misc fix

d492005

rupesh-k requested a review from daall June 30, 2020 18:08

rupesh-k added 2 commits June 30, 2020 12:04

Fixed validation

8696423

Fixed validation

8b332bb

abdosi reviewed Jul 1, 2020

View reviewed changes

daall approved these changes Jul 1, 2020

View reviewed changes

abdosi reviewed Jul 1, 2020

View reviewed changes

lguohan merged commit cfcb766 into sonic-net:master Jul 1, 2020

jleveque added acl-loader/aclshow config Enhancement labels Jul 12, 2020

abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020

Add support for port mirroring CLIs (sonic-net#936)

90dff47

* Add support for port mirroring CLIs Signed-off-by: Rupesh Kumar <rupesh-k.kumar@broadcom.com>

bingwang-ms mentioned this pull request Mar 25, 2022

Skip span mirror test on unsupported release sonic-net/sonic-mgmt#5400

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for port mirroring CLIs #936

Add support for port mirroring CLIs #936

rupesh-k commented Jun 4, 2020

rupesh-k commented Jun 24, 2020

rupesh-k commented Jun 25, 2020

kperumalbfn Jun 25, 2020

rupesh-k Jun 25, 2020

rupesh-k Jun 25, 2020

kperumalbfn Jun 25, 2020

rupesh-k Jun 25, 2020

daall left a comment

daall Jun 25, 2020

abdosi Jul 1, 2020

rupesh-k Jul 1, 2020

rupesh-k commented Jun 26, 2020

dev-aviz Jun 26, 2020

rupesh-k Jun 29, 2020

dev-aviz Jun 26, 2020

rupesh-k Jun 29, 2020

dev-aviz Jun 26, 2020

rupesh-k Jun 29, 2020

dev-aviz Jun 26, 2020

rupesh-k Jun 29, 2020

rupesh-k commented Jun 29, 2020

daall left a comment

rupesh-k commented Jun 29, 2020

rupesh-k commented Jun 30, 2020

amin-alavi commented Jun 30, 2020

rupesh-k commented Jun 30, 2020

amin-alavi commented Jun 30, 2020

abdosi Jul 1, 2020 •

edited

Loading

rupesh-k Jul 1, 2020

abdosi Jul 1, 2020

daall commented Jul 1, 2020

abdosi Jul 1, 2020

abdosi Jul 1, 2020


		print(tabulate.tabulate(data, headers=header, tablefmt="simple", missingval=""))
		if val.get("type") == "SPAN":

Add support for port mirroring CLIs #936

Add support for port mirroring CLIs #936

Conversation

rupesh-k commented Jun 4, 2020

rupesh-k commented Jun 24, 2020

rupesh-k commented Jun 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daall left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rupesh-k commented Jun 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rupesh-k commented Jun 29, 2020

daall left a comment

Choose a reason for hiding this comment

rupesh-k commented Jun 29, 2020

rupesh-k commented Jun 30, 2020

amin-alavi commented Jun 30, 2020

rupesh-k commented Jun 30, 2020

amin-alavi commented Jun 30, 2020

abdosi Jul 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daall commented Jul 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdosi Jul 1, 2020 •

edited

Loading