[dash] Implement PL and route group API #3048

theasianpianist · 2024-02-14T00:55:54Z

What I did

Implement SAI attributes needed for private link
Update dashorchs to use new route group API
Update existing DASH tests to use new route group API
Add new PL tests

This PR is dependent on the following:

(merged) sonic-dash-api changes to align with new APPL_DB database schema: Align with new HLD schema sonic-dash-api#20
(merged) sonic-swss-common changes to add new APPL_DB table names: Add new DASH APPL_DB table names sonic-swss-common#897
(merged) sonic-buildimage submodule update for the above two changes: [submodule][master] Update sonic-swss and sonic-dash-api submodules sonic-buildimage#19900
(PR open) sonic-dash-api change to add missing PL-related attribute, and the subsequent submodule update PR: Add PL underlay_sip field for DASH_ROUTE_TABLE sonic-dash-api#25
(PR open, but sairedi PR merge is dependent on this SWSS PR being merged first)) sonic-sairedis update to include new route group API changes: [saisubmodule] Update SAI submodule sonic-sairedis#1409

Merge plan is as follows:

This PR will update the AZP build to take artifacts from the above sonic-saireds PR build to allow testing of orchagent changes with update SAI headers.
Merge other intermediate PRs to get functionality working/tests passing. Once this PR has all checks passing, merge it.
Re-run the sonic-sairedis PR checks. The PR checks/VS tests should now pass. Merge once checks pass
Submit a new PR to swss to revert the AZP build back to taking the latest build artifacts from sonic-sairedis.

Why I did it

How I verified it

Details if related

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

…dash-pl

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

- Create outbound routing groups in SAI - Add ENI route entries to help map ENI->route group->route group OID - Update outbound routing key from ENI to route group. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

tests/dash/test_dash_pl.py

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

prsunny

ship it

*Use the latest master branch sairedis artifacts for building and testing #3048 changed the AZP jobs to use a specific sonic-sairedis build/artifact. This PR is reverting the sonic-sairedis build back to the latest master after sonic-sairedis breaking changes are merged.

mukeshmv · 2024-09-10T03:02:33Z

orchagent/dash/dashvnetorch.cpp

-    outbound_ca_to_pa_attrs.push_back(outbound_ca_to_pa_attr);
+    for (auto action: route_type_actions.items())
+    {
+        if (action.action_type() == dash::route_type::ACTION_TYPE_STATICENCAP)


@theasianpianist, UNDERLAY_DIP is not populated for static encap action. This will break the non PL case.

mukeshmv · 2024-09-10T03:04:37Z

orchagent/dash/dashvnetorch.cpp

+        outbound_ca_to_pa_attr.value.u32 = SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_PRIVATE_LINK_MAPPING;
+        outbound_ca_to_pa_attrs.push_back(outbound_ca_to_pa_attr);
+
+        outbound_ca_to_pa_attr.id = SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_UNDERLAY_DIP;


move UNDERLAY_DIP handling to static_encap action above. It is not specific to private link

sonic-net/sonic-swss#3048 moves DASH-specific VS tests into a separate folder

theasianpianist added 2 commits February 14, 2024 00:55

[dash] Implement PL API

c905608

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

fix parameter use

3ab9137

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from 3315276 to 3ab9137 Compare February 14, 2024 01:39

theasianpianist added 2 commits February 13, 2024 17:40

[dash] Implement PL API

0179272

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

fix parameter use

8bd8a0e

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from 3ab9137 to 8bd8a0e Compare February 14, 2024 01:40

theasianpianist added 4 commits February 14, 2024 02:59

fix routing_type parsing

ad81039

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Merge branch 'dash-pl' of github.com:theasianpianist/sonic-swss into …

e1be81c

…dash-pl

Set routing type table in dash_vnet test

1a7685d

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

add VS test for PL

11e374e

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from 199e6bb to 11e374e Compare February 14, 2024 22:52

Make ROUTING_TYPE_TABLE optional

37e347f

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from 8c46e76 to fd8397b Compare February 15, 2024 22:39

Set SAI PL attribute based on ROUTING_TYPE

134fd99

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from fd8397b to 134fd99 Compare February 16, 2024 08:25

theasianpianist added 2 commits August 7, 2024 07:22

Update DASH orchs to use route groups

0c26e58

- Create outbound routing groups in SAI - Add ENI route entries to help map ENI->route group->route group OID - Update outbound routing key from ENI to route group. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Merge branch 'master' of github.com:sonic-net/sonic-swss into dash-pl

9d8d664

theasianpianist force-pushed the dash-pl branch from 08e7bd3 to 9d8d664 Compare August 7, 2024 07:33

theasianpianist added 8 commits August 10, 2024 01:48

refactor tests

47a497e

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

use newest sairedis build

d8252ee

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

improve naming

49789b1

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

pin sairedis artifacts for route group changes

8cc622e

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

update DASH vnet tests for route group changes

8df9224

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Merge branch 'master' of github.com:sonic-net/sonic-swss into dash-pl

d84bb1b

update bulker for route group changes

e5eccb6

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

update PL dip/sip mask

cf41eed

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist changed the title ~~[dash] Implement PL API~~ [dash] Implement PL and route group API Aug 14, 2024

fix PL test config

aa2f1e7

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist marked this pull request as ready for review August 14, 2024 22:31

theasianpianist requested a review from prsunny as a code owner August 14, 2024 22:31

theasianpianist added 2 commits August 29, 2024 22:47

add ASIC_DB check helper

58b6e18

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

formatting fix

6b35f64

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

theasianpianist force-pushed the dash-pl branch from ed5320d to 6b35f64 Compare August 29, 2024 22:55

theasianpianist added 2 commits August 30, 2024 01:29

restructure PL tests

6923d1b

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

unbind old route group from ENI

ca712cc

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

jimmyzhai mentioned this pull request Sep 3, 2024

[saisubmodule] Update SAI submodule sonic-net/sonic-sairedis#1409

Merged

theasianpianist added 3 commits September 3, 2024 20:28

retry route group deletion if bound

52b6013

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

setup/teardown per test case

07408d6

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

add __init__.py for utils folder

e097983

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

mukeshmv reviewed Sep 4, 2024

View reviewed changes

tests/dash/test_dash_pl.py Outdated Show resolved Hide resolved

theasianpianist and others added 12 commits September 4, 2024 02:14

Merge branch 'master' of github.com:sonic-net/sonic-swss into dash-pl

e86e56d

fix test package

cf34994

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Test ENI route group rebinding

8ff6bb8

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

refactor orchagent mock base class

0d4859a

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

add dashorch UT

3c33ac1

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

add more route group tests

ae68c5a

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

fix build

8b3a3d6

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Update mock_orch_test.h

6fcb7af

fix test override error

9060640

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

define mock_orch_test base fns

a7e3ae5

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

restrict route removal from bound groups

3665aab

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

add more tests

f4af126

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

prsunny approved these changes Sep 6, 2024

View reviewed changes

prsunny merged commit 5fd7a05 into sonic-net:master Sep 6, 2024
17 checks passed

This was referenced Sep 6, 2024

[azp] Use master branch sairedis artifact #3279

Merged

[azp]Run DASH vs tests sonic-net/sonic-swss-common#913

Merged

mukeshmv reviewed Sep 10, 2024

View reviewed changes

qiluo-msft pushed a commit to sonic-net/sonic-swss-common that referenced this pull request Sep 10, 2024

run DASH vs tests (#913)

a76b983

sonic-net/sonic-swss#3048 moves DASH-specific VS tests into a separate folder

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dash] Implement PL and route group API #3048

[dash] Implement PL and route group API #3048

theasianpianist commented Feb 14, 2024 •

edited

Loading

prsunny left a comment

mukeshmv Sep 10, 2024 •

edited

Loading

mukeshmv Sep 10, 2024 •

edited

Loading

[dash] Implement PL and route group API #3048

[dash] Implement PL and route group API #3048

Conversation

theasianpianist commented Feb 14, 2024 • edited Loading

prsunny left a comment

Choose a reason for hiding this comment

mukeshmv Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

mukeshmv Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

theasianpianist commented Feb 14, 2024 •

edited

Loading

mukeshmv Sep 10, 2024 •

edited

Loading

mukeshmv Sep 10, 2024 •

edited

Loading