Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlag]Fix dynamic local fdb not save to state db #1932

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

pettershao-ragilenetworks
Copy link
Contributor

What I did
Fix dynamic local fdb not save to state db, issue is as below:

  1. Dual access for mlag
  2. active peer learn mac, stanby sync mac, so stanby device's fdb is static
  3. active peer mlag interface shutdown, so acitve device's fdb convert to peer link and static, stanby's fdb switch to dynamic
  4. clear fdb in stanby, issue appear, asic db cleared, but iccpd still exist fdb entry, either do acitve device.

Why I did it
If dynamic local fdb not save to state db, then clear fdb will fail to remove fdb entry in state db and iccpd will not got clear notification, fdb entry in iccpd will not sync with asic db, and peer device's fdb will not remove either.
How I verified it
clear fdb all
Details if related

@pettershao-ragilenetworks
Copy link
Contributor Author

@prsunny @Praveen-Brcm help check and forward this, thanks!

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comment

orchagent/fdborch.cpp Outdated Show resolved Hide resolved
@pettershao-ragilenetworks
Copy link
Contributor Author

@prsunny help forward this, thanks!

Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
@pettershao-ragilenetworks
Copy link
Contributor Author

check newest test case:test_mclagFdb_remote_to_local has passed.

@pettershao-ragilenetworks
Copy link
Contributor Author

@qiluo-msft @lguohan help merge this, thanks!

@pettershao-ragilenetworks
Copy link
Contributor Author

@gechiang help forward this, thanks!

Praveen-Brcm
Praveen-Brcm previously approved these changes Feb 8, 2022
@gechiang
Copy link
Contributor

gechiang commented Feb 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants