Fixed DPB system test cases to bring stability #1795

samaity · 2021-06-21T18:10:36Z

Signed-off-by: Sangita Maity samaity@linkedin.com

What I did
Fixed DPB system test cases to bring stability. Used setup_db for all dvs database and checked route interface only during Test.

Why I did it
to bring stability to test cases.
How I verified it

Details if related

lgtm-com · 2021-06-24T05:04:36Z

This pull request introduces 1 alert when merging 962d4f0 into c37cc1c - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-06-24T16:49:34Z

This pull request introduces 1 alert when merging 2021663 into c37cc1c - view on LGTM.com

new alerts:

1 for Unused local variable

Signed-off-by: Sangita Maity <samaity@linkedin.com>

prsunny · 2021-06-25T05:13:08Z

@samaity , almost all DPB tests started failing. Can you please take a look asap as this is failing on all PR builds

2021-06-24T22:07:50.0197995Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G0] FAILED [ 67%]
2021-06-24T22:08:05.3273736Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]0] FAILED [ 67%]
2021-06-24T22:08:20.6140091Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G1] FAILED [ 67%]
2021-06-24T22:08:35.8926637Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)0] FAILED [ 67%]
2021-06-24T22:08:51.0852718Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G2] FAILED [ 67%]
2021-06-24T22:09:06.2607801Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)0] FAILED [ 68%]
2021-06-24T22:09:21.4498592Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G3] FAILED [ 68%]
2021-06-24T22:09:23.7821494Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]0] PASSED [ 68%]
2021-06-24T22:09:38.9699459Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]1] FAILED [ 68%]
2021-06-24T22:09:54.1440221Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)1] FAILED [ 68%]
2021-06-24T22:10:09.3171950Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]2] FAILED [ 69%]
2021-06-24T22:10:24.5489410Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)1] FAILED [ 69%]
2021-06-24T22:10:39.7542097Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]3] FAILED [ 69%]
2021-06-24T22:10:42.1104153Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]1] PASSED [ 69%]
2021-06-24T22:10:57.3573963Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)2] FAILED [ 70%]
2021-06-24T22:11:12.5922279Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)2] FAILED [ 70%]
2021-06-24T22:11:27.8374098Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)3] FAILED [ 70%]
2021-06-24T22:11:30.1850031Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]2] PASSED [ 70%]
2021-06-24T22:11:45.4409483Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)3] FAILED [ 70%]
2021-06-24T22:11:47.7903891Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]3] PASSED [ 71%]
2021-06-24T22:12:03.0414342Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_with_vlan FAILED [ 71%]

samaity · 2021-06-25T22:18:43Z

@samaity , almost all DPB tests started failing. Can you please take a look asap as this is failing on all PR builds

2021-06-24T22:07:50.0197995Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G0] FAILED [ 67%]
2021-06-24T22:08:05.3273736Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]0] FAILED [ 67%]
2021-06-24T22:08:20.6140091Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G1] FAILED [ 67%]
2021-06-24T22:08:35.8926637Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)0] FAILED [ 67%]
2021-06-24T22:08:51.0852718Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G2] FAILED [ 67%]
2021-06-24T22:09:06.2607801Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)0] FAILED [ 68%]
2021-06-24T22:09:21.4498592Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G3] FAILED [ 68%]
2021-06-24T22:09:23.7821494Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]0] PASSED [ 68%]
2021-06-24T22:09:38.9699459Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]1] FAILED [ 68%]
2021-06-24T22:09:54.1440221Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)1] FAILED [ 68%]
2021-06-24T22:10:09.3171950Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]2] FAILED [ 69%]
2021-06-24T22:10:24.5489410Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)1] FAILED [ 69%]
2021-06-24T22:10:39.7542097Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]3] FAILED [ 69%]
2021-06-24T22:10:42.1104153Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]1] PASSED [ 69%]
2021-06-24T22:10:57.3573963Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)2] FAILED [ 70%]
2021-06-24T22:11:12.5922279Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)2] FAILED [ 70%]
2021-06-24T22:11:27.8374098Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)3] FAILED [ 70%]
2021-06-24T22:11:30.1850031Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]2] PASSED [ 70%]
2021-06-24T22:11:45.4409483Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)3] FAILED [ 70%]
2021-06-24T22:11:47.7903891Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]3] PASSED [ 71%]
2021-06-24T22:12:03.0414342Z test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_with_vlan FAILED [ 71%]

@prsunny, this is strange. It was perfectly fine a few days back. I am looking into this. We didn't make any change in the test file in recent times. I believe, some changes in the building code are failing these test cases as DPB is a highly dispersed topic. will get back soon with my findings. Thanks!

prsunny · 2021-06-26T00:30:15Z

@samaity , i agree we dint have recent changes related to DPB and this looks strange that many tests started failing. Could you check the logs (syslogs/swss.rec) from the build pipeline and see if there is any issue. You can get the logs from here. Look for log@1/log/test_port_dpb
https://dev.azure.com/mssonic/build/_build/results?buildId=21345&view=artifacts&pathAsName=false&type=publishedArtifacts

samaity · 2021-07-19T20:53:02Z

/azp run

azure-pipelines · 2021-07-19T20:53:08Z

Commenter does not have sufficient privileges for PR 1795 in repo Azure/sonic-swss

samaity force-pushed the swss_test_fix branch from 85dfbc3 to a57b98b Compare June 21, 2021 21:44

lguohan linked an issue Jun 23, 2021 that may be closed by this pull request

[VS test stability] DPB system tests #1778

Open

samaity force-pushed the swss_test_fix branch 2 times, most recently from cfbc8ce to 962d4f0 Compare June 24, 2021 04:58

samaity force-pushed the swss_test_fix branch from 962d4f0 to 2021663 Compare June 24, 2021 16:44

Fixed DPB system test cases to bring stability

4d9a313

Signed-off-by: Sangita Maity <samaity@linkedin.com>

samaity force-pushed the swss_test_fix branch from 2021663 to 4d9a313 Compare June 24, 2021 20:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed DPB system test cases to bring stability #1795

Fixed DPB system test cases to bring stability #1795

samaity commented Jun 21, 2021

lgtm-com bot commented Jun 24, 2021

lgtm-com bot commented Jun 24, 2021

prsunny commented Jun 25, 2021 •

edited

Loading

samaity commented Jun 25, 2021

prsunny commented Jun 26, 2021

samaity commented Jul 19, 2021

azure-pipelines bot commented Jul 19, 2021

Fixed DPB system test cases to bring stability #1795

Are you sure you want to change the base?

Fixed DPB system test cases to bring stability #1795

Conversation

samaity commented Jun 21, 2021

lgtm-com bot commented Jun 24, 2021

lgtm-com bot commented Jun 24, 2021

prsunny commented Jun 25, 2021 • edited Loading

samaity commented Jun 25, 2021

prsunny commented Jun 26, 2021

samaity commented Jul 19, 2021

azure-pipelines bot commented Jul 19, 2021

prsunny commented Jun 25, 2021 •

edited

Loading