upon cold reboot, skip remove mgmt vrf table from the kernel #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Mar 4, 2020
prsunny
reviewed
Mar 4, 2020
prsunny
approved these changes
Mar 4, 2020
|
retest this please |
1 similar comment
|
retest this please |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build-pr/1450/ looks like always nat test case failures. |
|
retest this please |
abdosi
pushed a commit
that referenced
this pull request
Mar 15, 2020
* upon cold reboot, skip remove mgmt vrf table from the kernel Co-authored-by: Bing Sun <Bing_Sun@dell.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ommands (sonic-net#1214) admin@sonic:~$ sudo connect line --devicename switch1 Successful connection to line 1 Press ^A ^X to disconnect admin@sonic:~$ sudo sonic-clear line --devicename switch1 admin@sonic:~$ sudo show line -b Line Baud PID Start Time Device ------ ------ ----- ------------ -------- 1 9600 - - switch1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In vrfmgr.cpp, for non-warm reboot case, skip removal of mgmt vrf table from the kernel.
Why I did it
mgmt vrf table in the kernel is installed via /etc/network/interfaces upon reboot, if vrfmgrd removes it after that, mgmt vrf table is missing in the kernel even though it is in the config db.
How I verified it
configure mgmt vrf and data VRF, save the configurations and do node reboot. After reboot, check mgmt vrf table is in the kernel.
Also check data VRFs are also present in the kernel.
Details if related
root@sonic:~# ip vrf show
Name Table
Vrf_red 1001
Vrf_green 1002
mgmt 5000 <<<<<<<<