Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schema] Add next hop group table to schema #475

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

TACappleman
Copy link
Contributor

No description provided.

@anshuv-mfst
Copy link

Hi @adamyeung - could you please add BRCM team to review this PR, thanks.

common/schema.h Outdated Show resolved Hide resolved
common/schema.h Outdated
@@ -39,6 +39,7 @@ namespace swss {
#define APP_FDB_TABLE_NAME "FDB_TABLE"
#define APP_PFC_WD_TABLE_NAME "PFC_WD_TABLE"
#define APP_SWITCH_TABLE_NAME "SWITCH_TABLE"
#define APP_NEXT_HOP_GROUP_TABLE_NAME "NEXT_HOP_GROUP_TABLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be renamed as APP_NEXTHOP_GROUP_TABLE_NAME instead of NEXT_HOP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

prsunny
prsunny previously approved these changes Aug 11, 2021
@TACappleman
Copy link
Contributor Author

@prsunny any idea what's causing the failing checks and if they'll work with a retry? I'm pretty confident that my 1 line addition of a #define isn't causing the issues!

@prsunny
Copy link
Contributor

prsunny commented Aug 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes Aug 13, 2021
@qiluo-msft
Copy link
Contributor

Could you rebase your code to latest master?

@TACappleman
Copy link
Contributor Author

@qiluo-msft Done

@TACappleman
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 475 in repo Azure/sonic-swss-common

@prsunny
Copy link
Contributor

prsunny commented Aug 13, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Contributor

prsunny commented Aug 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 4e4eb9d into sonic-net:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants