Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route flow counter related test cases #5736

Merged
merged 14 commits into from
Jun 7, 2022

Conversation

Junchao-Mellanox
Copy link
Contributor

@Junchao-Mellanox Junchao-Mellanox commented May 31, 2022

Description of PR

Summary:
Added test cases for route flow counter feature. HLD: sonic-net/SONiC#908

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Add route flow counter related test cases

How did you do it?

  1. Add new test case file test_route_flow_counter.py to covers basic function of this feature
  2. Add check in test_vnet_vxlan.py to cover VNET route
  3. Add check in test_bgp_speaker.py to cover BGP route
  4. Add check in test_static_route.py to cover static route

How did you verify/test it?

Run the test cases

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

Junchao-Mellanox and others added 10 commits February 14, 2022 09:53
Change-Id: I4b9b1dd1c5372645c67511ddcc667b99f427d556
Change-Id: I70d4fdd3160e7a31dfca66d829491b19630adc92
Conflicts:
	tests/vxlan/test_vnet_vxlan.py

Change-Id: Ia9bc3b3523c6c3f547a745ed1530fb7c143bac45
Change-Id: Iad925eaf3c605780e9d41802240ba89b8a4dce2f
Change-Id: I75d88cdd90244de99f832f154716ca6ad001c1b2
Change-Id: If6e571d803b7ba8702164f000ac7a0a10919f175
Change-Id: Ia784fc3ad19483fbc84ebd657066c0bce218c273
Change-Id: I89c90deabd38720136ab2dea5b1eb38283f1bcf2
Change-Id: I7b304d40004ea699c29d61d88b7bd1f64ec63a53
@Junchao-Mellanox
Copy link
Contributor Author

Hi @keboliu and @roysr-nv , could you please sign-off as there is no change compare to previous approved one?

@lgtm-com
Copy link

lgtm-com bot commented May 31, 2022

This pull request introduces 2 alerts when merging 8e31615 into a923c95 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2022

This pull request introduces 2 alerts when merging a9803fb into 6798d2b - view on LGTM.com

new alerts:

  • 2 for Unused import

@Junchao-Mellanox
Copy link
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Change-Id: I095c6c9be9f1fe9aef4d6e13307981fae5a481e8
keboliu
keboliu previously approved these changes Jun 2, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2022

This pull request introduces 2 alerts when merging 589528d into 9932069 - view on LGTM.com

new alerts:

  • 2 for Unused import

roy-sror
roy-sror previously approved these changes Jun 2, 2022
Change-Id: I7cdd6151d5fdf258f6d04ca1e0c897488900de97
@Junchao-Mellanox Junchao-Mellanox dismissed stale reviews from roy-sror and keboliu via 9daf6d1 June 6, 2022 01:54
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request introduces 3 alerts when merging 9daf6d1 into 0b86347 - view on LGTM.com

new alerts:

  • 3 for Unused import

@Junchao-Mellanox
Copy link
Contributor Author

Hi @liat-grozovik , could you please help merge this ?

@liat-grozovik liat-grozovik merged commit fdac684 into sonic-net:master Jun 7, 2022
@zhangyanzhao
Copy link
Contributor

zhangyanzhao commented Jun 13, 2022

@Junchao-Mellanox can you please add this code PR into sonic-net/SONiC#908 for tracking? Thanks.

@Junchao-Mellanox
Copy link
Contributor Author

@Junchao-Mellanox can you please add this code PR into sonic-net/SONiC#908 for tracking? Thanks.

Done

@Junchao-Mellanox Junchao-Mellanox deleted the route-flow-counter-1 branch June 13, 2022 05:28
@ZhaohuiS
Copy link
Contributor

@Junchao-Mellanox Does the script test_route_flow_counter support T1? Is the pytestmark same with test_static_router.py? Or it only supports mellanox?
Whatever same or not, could you please add pytestmark for this script? Otherwise it will skipped in our nightly test.
testcase route/test_route_flow_counter.py::TestRouteCounter::test_max_match_count is skipped when no topology marker is given

pytestmark = [
    pytest.mark.topology('t0'),
    pytest.mark.device_type('vs')
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants