Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012][celestica/silverstone]: Update platform driver and platform APIs #9911

Open
wants to merge 15 commits into
base: 202012
Choose a base branch
from

Conversation

mudsut4ke
Copy link
Contributor

Why I did it

  • Platform driver and APIs must support F2B and B2F SKUs
  • Platform APIs must passed all test cases in the SONIC Platform Testing Framework.

How I did it

  • Update platform driver to support latest firmware
  • Update Platform APIs to follow latest spec and fixes failed test cases
  • Update Silverstone Switch configuration

How to verify it

  • Run platform test on testbed

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

@lgtm-com
Copy link

lgtm-com bot commented Feb 3, 2022

This pull request introduces 5 alerts and fixes 30 when merging b727f23 into 73b27b7 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for Variable defined multiple times
  • 1 for Unnecessary pass

fixed alerts:

  • 11 for Unused import
  • 8 for Unused local variable
  • 6 for Except block handles 'BaseException'
  • 5 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Feb 7, 2022

This pull request introduces 2 alerts and fixes 30 when merging bda203e into 0ccd856 - view on LGTM.com

new alerts:

  • 1 for Unreachable code
  • 1 for Variable defined multiple times

fixed alerts:

  • 11 for Unused import
  • 8 for Unused local variable
  • 6 for Except block handles 'BaseException'
  • 5 for Wrong number of arguments in a class instantiation

@lguohan
Copy link
Collaborator

lguohan commented Mar 8, 2022

can you fix the lgtm?

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Mar 21, 2022

can you fix the lgtm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants