[YANG] Add route flow counter support #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
force-pushed
the
route-flow-counter
branch
2 times, most recently
from
e94fad0
to
3091693
Compare
dgsudharsan
suggested changes
Jan 22, 2022
dgsudharsan
previously approved these changes
Jan 25, 2022
|
@dgsudharsan could you please review following the changes request? |
|
@praveen-li will help to review. |
praveen-li
reviewed
Jan 28, 2022
src/sonic-yang-models/tests/yang_model_tests/tests_config/flex_counter.json
Show resolved
Hide resolved
src/sonic-yang-models/tests/yang_model_tests/tests_config/flex_counter.json
Show resolved
Hide resolved
|
@praveen-li, I have fixed all the comments, could you please review and sign-off? |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Feb 11, 2022
|
@prsunny could you please help to signoff? |
|
@prsunny , @qiluo-msft kindly reminder to signoff this PR |
keboliu
approved these changes
Mar 2, 2022
|
@prsunny , @qiluo-msft kindly reminder to signoff this PR |
prsunny
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#908
Why I did it
Add YANG models for route flow counters
How I did it
How to verify it
New unit test cases
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)