[Celestica] Add new platform SilverstoneX

[nicwu-cel]

Why I did it

Added Support for Celestica SilverstoneX platform

How I did it

Implemented the support for Celestica SilverstoneX platform

Platform: x86_64-cel_silverstone-x-r0
HwSKU: Silverstone-x
ASIC: innovium
ASIC Count: 1

How to verify it

Verified the show command outputs

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106

Description for the changelog

[Celestica] Add new platform SilverstoneX

A picture of a cute animal (not mandatory but encouraged)

[ghost]

All CLA requirements met.

[lgtm-com]

This pull request introduces 37 alerts when merging e8c0113 into d1f6596 - view on LGTM.com

new alerts:

• 16 for Unused import
• 12 for Except block handles 'BaseException'
• 4 for 'import *' may pollute namespace
• 2 for Should use a 'with' statement
• 1 for Module imports itself
• 1 for Unused local variable
• 1 for Wrong name for an argument in a class instantiation

[nicwu-cel]

Seems these 2 compiling failures are not related to platform code that we want to push. Could you check for this, thanks.

[Blueve]

Triggered re-run failed checks for this PR.
@nicwu-cel could you also address LGTM alerts?

[nicwu-cel]

Triggered re-run failed checks for this PR.
@nicwu-cel could you also address LGTM alerts?

OK, seems most of them are about the syntax of Python. Could I ignore them and merge this to 201911 branch? By the way, if I indeed need to fix these warnings, should I submit a new PR after I fix these alerts? Thanks

[Blueve]

OK, seems most of them are about the syntax of Python. Could I ignore them and merge this to 201911 branch? By the way, if I indeed need to fix these warnings, should I submit a new PR after I fix these alerts? Thanks

Why not fix them in current PR ; )
We must ensure PR will not introduce new alerts in release branches.

One more question, why this PR is not target to master branch? Are we plan to support this platform only for 201911?
Usually, we always put new feature to master branch first and then back port to release branch if need.

[nicwu-cel]

OK, seems most of them are about the syntax of Python. Could I ignore them and merge this to 201911 branch? By the way, if I indeed need to fix these warnings, should I submit a new PR after I fix these alerts? Thanks

Why not fix them in current PR ; )
We must ensure PR will not introduce new alerts in release branches.

One more question, why this PR is not target to master branch? Are we plan to support this platform only for 201911?
Usually, we always put new feature to master branch first and then back port to release branch if need.

OK, I'll fix these alerts in current PR.
We use 201911 branch to develop sonic_platform APIs with Python2 and we are not sure if it works in master branch or not. If it works in master branch, it's OK for us to put new feature to master branch first and then back port to 201911 branch.

[Blueve]

OK, I'll fix these alerts in current PR.
We use 201911 branch to develop sonic_platform APIs with Python2 and we are not sure if it works in master branch or not. If it works in master branch, it's OK for us to put new feature to master branch first and then back port to 201911 branch.

Thanks, please try master first. Usually we need forward compatibility and supported platform should always work in newest branch unless we have specific reason. @lguohan I would like to hear your suggestion.

[lgtm-com]

This pull request introduces 8 alerts when merging fec8ee3 into 1b168c3 - view on LGTM.com

new alerts:

• 4 for Unused import
• 1 for Unused local variable
• 1 for Except block handles 'BaseException'
• 1 for 'import *' may pollute namespace
• 1 for Wrong number of arguments in a class instantiation

[lgtm-com]

This pull request introduces 1 alert when merging 1006398 into 1b168c3 - view on LGTM.com

new alerts:

• 1 for Wrong name for an argument in a class instantiation

[nicwu-cel]

Seems the only alert is not a real alert because it meets Python syntax. Could we only push this code to 201911? Is there a comment from @lguohan? Thanks.

[sujinmkang]

@nicwu-cel Can we have show platform cli command output with this platform support? And sonic-mgmt/tests/platform_tests/api test result?

[lgtm-com]

This pull request introduces 1 alert when merging 583bf10 into 5b88d9e - view on LGTM.com

new alerts:

• 1 for Wrong name for an argument in a class instantiation