Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delta] Add support platform ag9032v2 #8360

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JohnsonYJLu
Copy link
Contributor

Signed-off-by: johnson johnson.lu@deltaww.com

Add support platform ag9032v2

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: johnson <johnson.lu@deltaww.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 11 alerts when merging e537b1b into c4e795f - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 3 for Unused import
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

can you fix lgtm?

@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

is the sonic platform python3 compatible? please make sure they are python3 compatible. we are deprecated python2 in the coming release.

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request introduces 11 alerts when merging 1a560d6 into e6ea527 - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 3 for Unused import
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

 into delta_ag9032v2

Signed-off-by: johnson <johnson.lu@deltaww.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request introduces 11 alerts when merging 4cf3822 into c668f2a - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 3 for Unused import
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

Signed-off-by: johnson <johnson.lu@deltaww.com>
@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request introduces 8 alerts when merging 7c124e2 into c668f2a - view on LGTM.com

new alerts:

  • 6 for Wrong number of arguments in a class instantiation
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace

@JohnsonYJLu JohnsonYJLu reopened this Sep 30, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2021

This pull request introduces 10 alerts when merging cf6a42d into 33e64a4 - view on LGTM.com

new alerts:

  • 6 for Wrong number of arguments in a class instantiation
  • 2 for Redundant assignment
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace

@JohnsonYJLu
Copy link
Contributor Author

is the sonic platform python3 compatible? please make sure they are python3 compatible. we are deprecated python2 in the coming release.

yes

@JohnsonYJLu JohnsonYJLu requested a review from a team as a code owner June 10, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants