[dhcp_relay] DHCP relay support for IPv6 #7772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomibitton
changed the title
This was referenced Jun 1, 2021
santoshdoke
previously approved these changes
Jun 28, 2021
tahmed-dev
suggested changes
Jul 1, 2021
Edit supervisord template to start DHCPv6 instance Align cfg unit test to new change Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
This was referenced Jul 4, 2021
@tahmed-dev I divided this PR into 3: |
tahmed-dev
reviewed
Jul 7, 2021
5 tasks
tahmed-dev
reviewed
Jul 9, 2021
dockers/docker-dhcp-relay/docker-dhcp-relay.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
3 tasks
tahmed-dev
pushed a commit
that referenced
this pull request
Jul 12, 2021
Why I did it Allow deploying DHCPv6 servers following the implementation PR: #7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
…es for easier code maintenance
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failure is not related to this change: |
tahmed-dev
reviewed
Jul 13, 2021
tahmed-dev
previously approved these changes
Jul 13, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 26, 2021
#### Why I did it Enhance DHCP monitor application following the implementation PR: #7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
#### Why I did it Enhance DHCP monitor application following the implementation PR: #7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
Why I did it Allow deploying DHCPv6 servers following the implementation PR: #7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it Allow deploying DHCPv6 servers following the implementation PR: sonic-net#7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
kellyyeh
pushed a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
Sep 29, 2021
Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance (cherry picked from commit 604becd)
5 tasks
kellyyeh
pushed a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
Sep 29, 2021
…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR. (cherry picked from commit bef5477)
5 tasks
kellyyeh
added a commit
that referenced
this pull request
Sep 30, 2021
5 tasks
5 tasks
|
This PR could not be cleanly cherry-pick to 202012. Please submit another PR. |
5 tasks
@qiluo-msft, kelly already created a new PR for this branch and it is merged, by PR: #8871 |
kellyyeh
pushed a commit
to sonic-net/sonic-dhcpmon
that referenced
this pull request
Oct 11, 2022
#### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net/sonic-buildimage#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only.
This will allow the IPv6 functionality along the IPv4 type.
How I did it
Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB.
Align cfg unit test to the new change.
Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT.
How to verify it
Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765
Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)