Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add support for set/get system led status #4829

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

- Why I did it

System health feature needs to set/get system led status

- How I did it

  1. Add a led object in chassis class and initialize it when the API is called on host side
  2. Read/write system led system fs to get/set the status

- How to verify it

Manual test on SN2700

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox
Copy link
Collaborator Author

Retest vsimage please

@sujinmkang
Copy link
Collaborator

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

@Junchao-Mellanox
Copy link
Collaborator Author

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

No, we cannot for now because driver doesn't put the LED status to that file as I tested.

@Junchao-Mellanox
Copy link
Collaborator Author

Retest vsimage please.

@keboliu
Copy link
Collaborator

keboliu commented Jul 7, 2020

retest vsimage please

@keboliu keboliu requested a review from jleveque July 13, 2020 09:59
@jleveque jleveque merged commit 76d68ad into sonic-net:master Jul 13, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the system-led-api branch September 18, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants