[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked #18829

mlok-nokia · 2024-04-30T03:06:24Z

Why I did it

on Master branch, dhcp_relay is not supported in VOQ chassis. It is disabled in the FEATURE table. But based on the dependency, swss.sh always call "systemctl start" it although it's service file has been masked/disabled. The following error is logged in syslog which causes the logAnalyze failed on some of the OC tests. Fix issue #18822

Work item tracking

Microsoft ADO (number only):

How I did it

Added code to swss.sh to check if service is disabled or not. If it is disabled, do not start the service although it is in the DPENDENT_LIST. This avoids the ERROR log shown up in the syslog file

How to verify it

Reboot the system or execut the config reload. The following error messages should not be seen in the syslog file

Apr 27 23:15:14.472425 ixre-egl-board7 ERR systemctl[7299]: Failed to start dhcp_relay.service: Unit dhcp_relay.service is masked.
Apr 27 23:15:14.476897 ixre-egl-board7 ERR systemctl[7298]: Failed to start dhcp_relay.service: Unit dhcp_relay.service is masked.

Which release branch to backport (provide reason below if selected)

This issue only exist in Master branch which is using the newer version of kernel.

Tested branch (Please provide the tested image version)

tested on Master branch.

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

rlhui · 2024-05-01T17:16:29Z

@kellyyeh please review this at earliest, thanks.

wenyiz2021

would like to keep an eye on this PR.

we have seen similar issue where sup has bgp disabled but not masked, and swss startup also starts bgp which caused an issue. there is #15734 to fix that.

this PR LGTM as a more general fix.

mlok-nokia · 2024-05-08T15:19:52Z

@lguohan @kellyyeh Please help to review and merge this PR. Thanks

judyjoseph

LGTM, the only case is if the service is delayed and hostcfg sets the FEATURE state to enable/disable later -- which seems not the case with dhcp_relay service.

wenyiz2021 · 2024-05-15T22:35:44Z

hi @lguohan / @yxieca , could you help merge?

yxieca · 2024-05-15T22:53:08Z

hi @lguohan / @yxieca , could you help merge?

This change is generally in the right direction. I am surprised that it only affected dhcp relay. @qiluo-msft , @saiarcot895 do you have other concerns for the change?

wenyiz2021 · 2024-05-15T22:55:24Z

hi @lguohan / @yxieca , could you help merge?

This change is generally in the right direction. I am surprised that it only affected dhcp relay. @qiluo-msft , @saiarcot895 do you have other concerns for the change?

we have seen similar issue where sup has bgp disabled but not masked, and swss startup also starts bgp which caused an issue. there was #15734 to fix that.
current PR fix looks more general

saiarcot895 · 2024-05-15T23:03:36Z

For swss, there's also the docker-wait-any script that gets started as part of the wait command (this basically checks to see if one of the dependent containers have exited; if so, it brings down this container). That might need to be modified as well here?

files/scripts/swss.sh

mlok-nokia · 2024-05-22T16:27:19Z

For swss, there's also the docker-wait-any script that gets started as part of the wait command (this basically checks to see if one of the dependent containers have exited; if so, it brings down this container). That might need to be modified as well here?

For this particular issue, it only happens on the variable "DEPENDENT". The docker-wait-any is using a variable "MULTI_INST_DEPENDENT". No need to modify for docker-wait-any.

yaqiangz

LGTM

rlhui · 2024-06-19T17:50:32Z

@prabhataravind would you be able to review/approve, so that this PR could be merged? thanks.

files/scripts/swss.sh

…e althoug it is masked Signed-off-by: mlok <marty.lok@nokia.com>

prabhataravind

The latest change looks good to me.

prabhataravind · 2024-06-26T18:23:26Z

@prabhataravind would you be able to review/approve, so that this PR could be merged? thanks.

@rlhui Reviewed and approved the latest diff.

kperumalbfn · 2024-08-02T18:38:09Z

files/scripts/swss.sh

-            /bin/systemctl start ${dep}
+            if [[ $dep == "dhcp_relay" ]]; then
+                state=$(is_feature_enabled $dep)
+                if [[ $state == "true" ]]; then


After starting the service, should we enable the feature flag for this service?

yaqiangz · 2024-08-21T06:30:17Z

Hi @yxieca are we good to merge this PR?

…e although it is masked (sonic-net#18829) * [voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service althoug it is masked Signed-off-by: mlok <marty.lok@nokia.com>

mssonicbld · 2024-09-06T21:44:02Z

Cherry-pick PR to 202405: #20182

…e although it is masked (#18829) * [voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service althoug it is masked Signed-off-by: mlok <marty.lok@nokia.com>

…e although it is masked (sonic-net#18829) * [voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service althoug it is masked Signed-off-by: mlok <marty.lok@nokia.com>

mlok-nokia requested a review from lguohan as a code owner April 30, 2024 03:06

rlhui requested a review from kellyyeh May 1, 2024 17:13

wenyiz2021 approved these changes May 1, 2024

View reviewed changes

judyjoseph previously approved these changes May 10, 2024

View reviewed changes

yxieca requested a review from yaqiangz May 15, 2024 18:20

kellyyeh approved these changes May 15, 2024

View reviewed changes

yxieca requested review from qiluo-msft and saiarcot895 May 15, 2024 22:52

wumiaont reviewed May 20, 2024

View reviewed changes

files/scripts/swss.sh Outdated Show resolved Hide resolved

prsunny requested a review from prabhataravind May 21, 2024 18:29

mlok-nokia dismissed judyjoseph’s stale review via cd9ddcb May 22, 2024 16:17

mlok-nokia force-pushed the dhcp_relay_issue branch from 2c21ab5 to cd9ddcb Compare May 22, 2024 16:17

yaqiangz approved these changes Jun 3, 2024

View reviewed changes

wenyiz2021 mentioned this pull request Jun 5, 2024

[master][voq][chassis] swss.sh "systemctl start" dhcp_relay failed and log error which causes logAnalyze failure in OC test #18822

Open

rlhui assigned mlok-nokia Jun 12, 2024

mlok-nokia force-pushed the dhcp_relay_issue branch from cd9ddcb to 5f12fdf Compare June 12, 2024 20:16

prabhataravind reviewed Jun 20, 2024

View reviewed changes

files/scripts/swss.sh Outdated Show resolved Hide resolved

[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay servic…

c354e20

…e althoug it is masked Signed-off-by: mlok <marty.lok@nokia.com>

mlok-nokia force-pushed the dhcp_relay_issue branch from 5f12fdf to 91b0986 Compare June 26, 2024 17:57

Address comment. Add check for dhcp_relay service only

91b0986

prabhataravind approved these changes Jun 26, 2024

View reviewed changes

judyjoseph approved these changes Aug 2, 2024

View reviewed changes

kperumalbfn reviewed Aug 2, 2024

View reviewed changes

yxieca merged commit c5a620b into sonic-net:master Aug 21, 2024
20 checks passed

rlhui added the Request for 202405 Branch label Sep 4, 2024

bingwang-ms added the Approved for 202405 Branch label Sep 6, 2024

mssonicbld mentioned this pull request Sep 6, 2024

[action] [PR:18829] [voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked (#18829) #20182

Merged

mssonicbld added the Created PR to 202405 Branch label Sep 6, 2024

mssonicbld added Included in 202405 Branch and removed Created PR to 202405 Branch labels Sep 7, 2024

mlok-nokia deleted the dhcp_relay_issue branch September 27, 2024 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked #18829

[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked #18829

mlok-nokia commented Apr 30, 2024 •

edited

Loading

rlhui commented May 1, 2024

wenyiz2021 left a comment

mlok-nokia commented May 8, 2024

judyjoseph left a comment

wenyiz2021 commented May 15, 2024

yxieca commented May 15, 2024

wenyiz2021 commented May 15, 2024

saiarcot895 commented May 15, 2024 •

edited

Loading

mlok-nokia commented May 22, 2024

yaqiangz left a comment

rlhui commented Jun 19, 2024

prabhataravind left a comment

prabhataravind commented Jun 26, 2024 •

edited

Loading

kperumalbfn Aug 2, 2024

yaqiangz commented Aug 21, 2024

mssonicbld commented Sep 6, 2024

[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked #18829

[voq][chassis][dhcp_relay] swss.sh try to start the dhcp_relay service although it is masked #18829

Conversation

mlok-nokia commented Apr 30, 2024 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

rlhui commented May 1, 2024

wenyiz2021 left a comment

Choose a reason for hiding this comment

mlok-nokia commented May 8, 2024

judyjoseph left a comment

Choose a reason for hiding this comment

wenyiz2021 commented May 15, 2024

yxieca commented May 15, 2024

wenyiz2021 commented May 15, 2024

saiarcot895 commented May 15, 2024 • edited Loading

mlok-nokia commented May 22, 2024

yaqiangz left a comment

Choose a reason for hiding this comment

rlhui commented Jun 19, 2024

prabhataravind left a comment

Choose a reason for hiding this comment

prabhataravind commented Jun 26, 2024 • edited Loading

kperumalbfn Aug 2, 2024

Choose a reason for hiding this comment

yaqiangz commented Aug 21, 2024

mssonicbld commented Sep 6, 2024

mlok-nokia commented Apr 30, 2024 •

edited

Loading

saiarcot895 commented May 15, 2024 •

edited

Loading

prabhataravind commented Jun 26, 2024 •

edited

Loading