Dev cli sessions #17623

i-davydenko · 2023-12-26T22:23:53Z

Why I did it
Give ability to:

configure limit for active login sessions.
configure ssh-server / serial console autologout timeout
configure sysrq-capabilities (enable / disable)

Work item tracking
Microsoft ADO (number only):

How I did it
Add new service that responsible for serial configuration;
Update existing flows for extended ssh-server configurations in hostcfgd;
Add YANG model to support new configuration.

How to verify it
Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog
Link to config_db schema for YANG module changes
ssh_server
serial_console

A picture of a cute animal (not mandatory but encouraged)
kitty - Cube

linux-foundation-easycla · 2023-12-26T22:23:58Z

The committers listed above are authorized under a signed CLA.

✅ login: i-davydenko (987a19f, 18f246c, 64cf56c, 24a9da0, 4a4aa75, 2539a1d, 0940eea)

i-davydenko · 2024-03-04T17:18:30Z

Hi @lguohan , Hi @qiluo-msft
Could you please review the changes here and in other related submodules :)

qiluo-msft · 2024-03-18T06:56:18Z

src/sonic-yang-models/yang-models/sonic-ssh-server.yang

@@ -40,6 +45,20 @@ module sonic-ssh-server {
                        }
                    }
                }
+                leaf inactivity_timeout {
+                    description "inactivity timeout (in minutes), 0 means no timeout";
+                    default 15;


15

How do you pick the default value? Is it the linux default behavior in old image without this feature? #Closed

@qiluo-msft hi, yes, this is old defaults in sonic

qiluo-msft · 2024-03-18T06:56:36Z

src/sonic-yang-models/yang-models/sonic-serial-console.yang

+	                type int32 {
+	                    range "0..35000";
+	                }
+	                default 15;


15

How do you pick the default value? Is it the linux default behavior in old image without this feature? #Closed

@qiluo-msft hi, yes, this is old defaults in sonic

qiluo-msft · 2024-03-18T06:57:13Z

src/sonic-yang-models/yang-models/sonic-serial-console.yang

@@ -0,0 +1,37 @@
+//filename:  sonic-serial-console.yang
+module sonic-serial-console {


module

@ganglyu @wen587 @isabelmsft Please help review the 2 Yang models.

@i-davydenko
Can you create separate PR for sonic yang models?

@i-davydenko is there a PR for yang? can you please share?
also please add it to the HLD list of PRs for the feature

This commnet is still active.

wen587 · 2024-03-18T07:18:54Z

src/sonic-yang-models/yang-models/sonic-serial-console.yang

+
+	            leaf sysrq_capabilities {
+	                description "managing SysRq capabilities";
+	                type enumeration {


suggest to reuse admin_mode https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L127

@wen587 done

…ded ssh-server tree.

update tests for ssh-server model

qiluo-msft · 2024-05-15T16:51:40Z

Please reduce the "force-pushed" usage, which invalidated all the previous review status.

…types.

i-davydenko · 2024-05-22T14:17:02Z

@qiluo-msft not sure how to handle ms_conflict — MS conflict detect. Could you please advise what should I do?
Do I need to message someone from MS team?

liat-grozovik · 2024-05-22T16:18:59Z

/azpw run ms_conflict

i-davydenko · 2024-05-24T20:23:09Z

/azpw run ms_conflict

mssonicbld · 2024-05-24T20:23:12Z

/AzurePipelines run ms_conflict

azure-pipelines · 2024-05-24T20:23:18Z

No pipelines are associated with this pull request.

i-davydenko · 2024-05-28T08:59:05Z

/azpw run

mssonicbld · 2024-05-28T08:59:07Z

/AzurePipelines run

azure-pipelines · 2024-05-28T08:59:24Z

Azure Pipelines successfully started running 1 pipeline(s).

i-davydenko · 2024-05-28T15:13:24Z

/azpw run

mssonicbld · 2024-05-28T15:13:27Z

/AzurePipelines run

azure-pipelines · 2024-05-28T15:13:42Z

Azure Pipelines successfully started running 1 pipeline(s).

i-davydenko · 2024-05-28T15:16:22Z

@StormLiangMS,@liushilongbuaa can you help please? What should I do with this ms_conflict run?
PR: #17623 is conflict with MS internal repo

HLD: sonic-net/SONiC#1367 | Module name | PR | state | context | | ------------- | ------------- | ----|-----| | [sonic-buildimage](https://github.com/sonic-net/sonic-buildimage) | [Dev cli sessions](sonic-net/sonic-buildimage#17623) | ![GitHub issue/pull request detail](https://img.shields.io/github/pulls/detail/state/sonic-net/sonic-buildimage/17623) | ![GitHub pull request check contexts](https://img.shields.io/github/status/contexts/pulls/sonic-net/sonic-buildimage/17623) | | [sonic-host-services](https://github.com/sonic-net/sonic-host-services) | [cli-sessions](sonic-net/sonic-host-services#99) | ![GitHub issue/pull request detail](https://img.shields.io/github/pulls/detail/state/sonic-net/sonic-host-services/99) | ![GitHub pull request check contexts](https://img.shields.io/github/status/contexts/pulls/sonic-net/sonic-host-services/99) | | [sonic-utilities](https://github.com/sonic-net/sonic-utilities) | [SONIC CLI for CLI-Sessions feature #3175](#3175) | ![GitHub issue/pull request detail](https://img.shields.io/github/pulls/detail/state/sonic-net/sonic-utilities/3175) | ![GitHub pull request check contexts](https://img.shields.io/github/status/contexts/pulls/sonic-net/sonic-utilities/3175) | #### What I did Implement next commands for CLI-sessions feature: - config serial-console inactivity-timeout - config serial-console sysrq-capabilities - show serial-console - config ssh max-sessions - config ssh inactivity-timeout - show ssh #### How I did it Write handlers in config/main.py for serial-console and ssh commands to cover configuration set; Write handlers in show/main.py for serial-console and ssh to cover show commands. #### How to verify it Manual tests

i-davydenko requested review from qiluo-msft and lguohan as code owners December 26, 2023 22:23

i-davydenko force-pushed the dev-cli-sessions branch 2 times, most recently from ea0b9f3 to 9e2bdcf Compare January 10, 2024 22:11

qiluo-msft requested a review from liuh-80 March 18, 2024 06:52

qiluo-msft reviewed Mar 18, 2024

View reviewed changes

qiluo-msft requested a review from ganglyu March 18, 2024 06:56

qiluo-msft reviewed Mar 18, 2024

View reviewed changes

qiluo-msft requested review from wen587 and isabelmsft March 18, 2024 06:57

wen587 reviewed Mar 18, 2024

View reviewed changes

i-davydenko mentioned this pull request Apr 17, 2024

HLD for cli sessions feature sonic-net/SONiC#1367

Merged

This was referenced Apr 30, 2024

[cli-sessions] sonic-net/sonic-host-services#99

Merged

SONIC CLI for CLI-Sessions feature sonic-net/sonic-utilities#3175

Merged

i-davydenko and others added 4 commits April 30, 2024 16:19

[cli-sessions] update configuration templates, default configs

2539a1d

[cli-sessions] Update YAML models with new serial-console tree, exten…

0940eea

…ded ssh-server tree.

[cli-sessions] Implement tests for serial-console model,

64cf56c

update tests for ssh-server model

Fix comment that points to config-file generator.

4a4aa75

i-davydenko force-pushed the dev-cli-sessions branch from 0b58b74 to 4a4aa75 Compare April 30, 2024 13:21

Reuse admin_mode instead of new enum definition.

18f246c

qiluo-msft previously approved these changes May 15, 2024

View reviewed changes

i-davydenko and others added 2 commits May 22, 2024 01:04

Merge branch 'sonic-net:master' into dev-cli-sessions

24a9da0

[cli-sessions] Fix sonic-serial-console.yang model by importing base …

987a19f

…types.

i-davydenko dismissed qiluo-msft’s stale review via 987a19f May 21, 2024 23:37

fastiuk closed this May 30, 2024

fastiuk reopened this May 30, 2024

qiluo-msft approved these changes Aug 13, 2024

View reviewed changes

qiluo-msft merged commit 367495d into sonic-net:master Sep 16, 2024
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev cli sessions #17623

Dev cli sessions #17623

i-davydenko commented Dec 26, 2023 •

edited by liat-grozovik

Loading

linux-foundation-easycla bot commented Dec 26, 2023 •

edited

Loading

i-davydenko commented Mar 4, 2024

qiluo-msft Mar 18, 2024 •

edited

Loading

i-davydenko Apr 19, 2024

qiluo-msft Mar 18, 2024 •

edited

Loading

i-davydenko Apr 19, 2024

qiluo-msft Mar 18, 2024 •

edited

Loading

ganglyu Mar 18, 2024

liat-grozovik May 22, 2024

qiluo-msft Aug 13, 2024

wen587 Mar 18, 2024

i-davydenko Apr 30, 2024

qiluo-msft commented May 15, 2024

i-davydenko commented May 22, 2024

liat-grozovik commented May 22, 2024 •

edited

Loading

i-davydenko commented May 24, 2024

mssonicbld commented May 24, 2024

azure-pipelines bot commented May 24, 2024

i-davydenko commented May 28, 2024

mssonicbld commented May 28, 2024

azure-pipelines bot commented May 28, 2024

i-davydenko commented May 28, 2024

mssonicbld commented May 28, 2024

azure-pipelines bot commented May 28, 2024

i-davydenko commented May 28, 2024

		@@ -0,0 +1,37 @@
		//filename: sonic-serial-console.yang
		module sonic-serial-console {

Dev cli sessions #17623

Dev cli sessions #17623

Conversation

i-davydenko commented Dec 26, 2023 • edited by liat-grozovik Loading

linux-foundation-easycla bot commented Dec 26, 2023 • edited Loading

i-davydenko commented Mar 4, 2024

qiluo-msft Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

i-davydenko Apr 19, 2024

Choose a reason for hiding this comment

qiluo-msft Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

i-davydenko Apr 19, 2024

Choose a reason for hiding this comment

qiluo-msft Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

ganglyu Mar 18, 2024

Choose a reason for hiding this comment

liat-grozovik May 22, 2024

Choose a reason for hiding this comment

qiluo-msft Aug 13, 2024

Choose a reason for hiding this comment

wen587 Mar 18, 2024

Choose a reason for hiding this comment

i-davydenko Apr 30, 2024

Choose a reason for hiding this comment

qiluo-msft commented May 15, 2024

i-davydenko commented May 22, 2024

liat-grozovik commented May 22, 2024 • edited Loading

i-davydenko commented May 24, 2024

mssonicbld commented May 24, 2024

azure-pipelines bot commented May 24, 2024

i-davydenko commented May 28, 2024

mssonicbld commented May 28, 2024

azure-pipelines bot commented May 28, 2024

i-davydenko commented May 28, 2024

mssonicbld commented May 28, 2024

azure-pipelines bot commented May 28, 2024

i-davydenko commented May 28, 2024

i-davydenko commented Dec 26, 2023 •

edited by liat-grozovik

Loading

linux-foundation-easycla bot commented Dec 26, 2023 •

edited

Loading

qiluo-msft Mar 18, 2024 •

edited

Loading

qiluo-msft Mar 18, 2024 •

edited

Loading

qiluo-msft Mar 18, 2024 •

edited

Loading

liat-grozovik commented May 22, 2024 •

edited

Loading