Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipPublishDocMs from ci.yml files in JS repo for files that were turned off due to type2docfx #26770

Open
danieljurek opened this issue Aug 10, 2023 · 2 comments · May be fixed by #31207
Open

Remove skipPublishDocMs from ci.yml files in JS repo for files that were turned off due to type2docfx #26770

danieljurek opened this issue Aug 10, 2023 · 2 comments · May be fixed by #31207
Assignees
@danieljurek
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

Once the @microsoft/type2docfx package is integrated into the build system, skipPublishDocMs can be removed from ci.yml files as they are excluded by false positives in our validation infrastructure.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 10, 2023
@xirzec xirzec added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 10, 2023
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 10, 2023
@xirzec
Copy link
Member

xirzec commented Aug 10, 2023

@danieljurek is this something you want the JS team to take care of or is this a reminder for EngSys folks?

@danieljurek danieljurek self-assigned this Aug 10, 2023
@danieljurek
Copy link
Member Author

@xirzec -- I'll handle this as part of integrating @microsoft/type2docfx ... I'm putting up a PR right now that skips docs ms publishing for a few packages that generate false errors in our validation heuristics.

@danieljurek danieljurek mentioned this issue Aug 10, 2023
Merged
danieljurek added a commit that referenced this issue Aug 10, 2023
@danieljurek
Add skipPublishDocMs to false error reports in docs heuristics (#26773)
5dd56f5 
Example pipeline fixed by this change: 

* Identity --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995011&view=results
* Core --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995180&view=logs&j=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b&t=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b

Work item to undo this when we integrate `@microsoft/type2docfx`
#26770
dgetu pushed a commit that referenced this issue Sep 6, 2023
@danieljurek @dgetu
Add skipPublishDocMs to false error reports in docs heuristics (#26773)
4bb8f6a 
Example pipeline fixed by this change: 

* Identity --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995011&view=results
* Core --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995180&view=logs&j=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b&t=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b

Work item to undo this when we integrate `@microsoft/type2docfx`
#26770
@jeremymeng jeremymeng mentioned this issue Aug 6, 2024
Merged
jeremymeng added a commit that referenced this issue Aug 7, 2024
@jeremymeng
[core-rest-pipeline] enable publishing docs (#30675)
ddbf627 
as there's no more pending work for issue #26770
@JimSuplizio JimSuplizio changed the title Remove skipPublishDocMs from ci.yml files Remove skipPublishDocMs from ci.yml files in JS repo for files that were turned off due to type2docfx Sep 13, 2024
@danieljurek danieljurek linked a pull request Sep 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljurek danieljurek

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
Azure SDK EngSys 📈
Status: 🔬 Dev in PR
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable publishing for packages previously excluded from Docs MS Azure/azure-sdk-for-js
2 participants
@xirzec @danieljurek