Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mgmt] generation failure for format: arm-id #1483

Closed
msyyc opened this issue Sep 29, 2022 · 2 comments · Fixed by #1489
Closed

[Mgmt] generation failure for format: arm-id #1483

msyyc opened this issue Sep 29, 2022 · 2 comments · Fixed by #1489
Assignees
Labels
mgmt This issue is related to a management-plane library.

Comments

@msyyc
Copy link
Member

msyyc commented Sep 29, 2022

After upgrade modelerfour to 4.24.3, we need to be compatible with type: arm-id in the output of modelerfour:
image

Once it is fixed, we can remove the directive: Azure/azure-rest-api-specs@815ef75

@msyyc msyyc added the mgmt This issue is related to a management-plane library. label Sep 29, 2022
@msyyc msyyc self-assigned this Sep 29, 2022
@iscai-msft
Copy link
Contributor

@msyyc I thought the fix you made for "uuid" format would also solve this? We should just do string if it's a string schema with a format

@msyyc
Copy link
Member Author

msyyc commented Sep 30, 2022

@iscai-msft Yeah, I think it is related with

if type_group in ("string", "uuid", "uri"):
. Since there are many PR and release issues related with feature, I have to fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants