Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Signup: Adding smoke tests #94747

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Sep 20, 2024

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1136

Proposed Changes

  • This PR adds basic smoke tests to the A4A signup page

Testing Instructions

Ensure the following build configurations are passing:

  • Calypso E2E (desktop)
  • Jetpack E2E Simple (mobile)
  • Jetpack E2E Simple (desktop)
  • Jetpack E2E AT (desktop)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin marked this pull request as draft September 20, 2024 07:26
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin changed the title Testing A4A >Signup : Adding smoke tests Sep 20, 2024
@yashwin yashwin changed the title A4A >Signup : Adding smoke tests A4A > Signup : Adding smoke tests Sep 20, 2024
@yashwin yashwin changed the title A4A > Signup : Adding smoke tests A4A > Signup: Adding smoke tests Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants