Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Fonts are not shown in the Editor preview #76649

Closed
liviopv opened this issue May 6, 2023 · 13 comments
Closed

Google Fonts are not shown in the Editor preview #76649

liviopv opened this issue May 6, 2023 · 13 comments
Labels
[Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature] Google Fonts Integration with Google Fonts for custom typography on sites. [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Atomic [Platform] Simple [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug

Comments

@liviopv
Copy link

liviopv commented May 6, 2023

Quick summary

When selecting a custom font family from our Google Fonts list in Global Styles or blocks Typography controls, the font is not applied correctly in the editor preview but appears on the front end.

CleanShot.2023-05-06.at.09.44.25.mp4

Fonts that are part of the theme style variations can be previewed. This is broken in Simple and Atomic sites on Gutenberg 15.7.

On an Atomic site, when Gutenberg is inactive, the list of fonts is not available at all:

CleanShot 2023-05-06 at 09 56 38@2x

I couldn't reproduce any similar behavior in a local site with and without Gutenberg 15.7.

Steps to reproduce

  1. In a site with an FSE theme and access to Global Styles, open the Site Editor
  2. Go to Global Styles > Typography
  3. Select a font from our Google Fonts selection, like Space Mono
  4. The preview will flash as if it was applying the font, but it won't be applied correctly. Instead, a serif system font will load.

What you expected to happen

The preview should show the correct font selection

What actually happened

The Editor will not show any fonts from Google Fonts in the preview.

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Gutenberg 15.7
Mac OS Ventura 13.0.1
Chrome 112.0

@liviopv liviopv added [Type] Bug [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High [Feature] Google Fonts Integration with Google Fonts for custom typography on sites. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. labels May 6, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Atomic [Platform] Simple labels May 6, 2023
@rw-ye
Copy link

rw-ye commented May 7, 2023

Another report: 6267935-zd-woothemes

@github-actions
Copy link

github-actions bot commented May 7, 2023

Support References

This comment is automatically generated. Please do not edit it.

@autumnfjeld
Copy link
Contributor

cc: @arthur791004

@simison
Copy link
Member

simison commented May 8, 2023

Confirmed this is with Gutenberg 15.7, and doesn't happen when I switch to Gutenberg 15.6.2 on simple sites:

15.6.2
Screenshot 2023-05-08 at 12 42 50

15.7
Screenshot 2023-05-08 at 12 43 48

@arthur791004
Copy link
Contributor

@hellofromtonya
Copy link

It's related to https://github.com/WordPress/gutenberg/pull/49655/files#r1185738007

WordPress/gutenberg#49655 removed the decision-making logic of which fonts to print for the iframed editor for the 6.3 compat script-loader (it's still in the 6.2 compat file). That code is being relocated to the Fonts API (see WordPress/gutenberg#50151).

A 15.7.1 minor will contain this follow-up PR which should restore printing of fonts in the Site Editor and other block editors.

@cat-og
Copy link

cat-og commented May 9, 2023

Another report here: 6272049-zd

@RT-1904129
Copy link

Hi @hellofromtonya , @arthur791004
Can you help me to set up this project in my locally as I follow all step but when I am doing yarn start it still scrolling and I am not able to see the correct UI from the last 2 hours in my local
Thanks & Regards
Rishabh Tripathi

@simison
Copy link
Member

simison commented May 9, 2023

@RT-1904129 unfortunately this issue needs some internal tooling to debug & solve, and we have folks working on this already.

@RT-1904129
Copy link

Hi @simison
Basically, I want little help in setup this project. Can you help me on this?
Thanks & Regards
Rishabh Tripathi

@simison
Copy link
Member

simison commented May 9, 2023

@RT-1904129 please see:

@cuemarie
Copy link

cuemarie commented May 9, 2023

📌 ACTIONS

  • Assigned to Other @Automattic/t-rex since this is related to Global styles, but see discussion below:
  • Troubleshooting and a fix is in discussion here: p1683364993859039-slack-C02FMH4G8

@dsas
Copy link
Contributor

dsas commented May 10, 2023

GB 15.7.1 was rolled out to WordPress.com at 19:56 UTC yesterday, which looks to have fixed this bug as @hellofromtonya suggested.

@dsas dsas closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature] Google Fonts Integration with Google Fonts for custom typography on sites. [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Atomic [Platform] Simple [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug
Projects
None yet
Development

No branches or pull requests

10 participants