Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3P) Block Previews: Update headstart annotation & API #34977

Closed
4 tasks
obenland opened this issue Jul 29, 2019 · 2 comments
Closed
4 tasks

(3P) Block Previews: Update headstart annotation & API #34977

obenland opened this issue Jul 29, 2019 · 2 comments

Comments

@obenland
Copy link
Member

Dependent on:
WordPress/gutenberg#16033
WordPress/gutenberg#16113
WordPress/gutenberg#16801

  • Remove images from headstartdata.
  • Update the FSE mu-plugin to not include preview images in headstart annotation.
  • Regenerate headstart annotation.
  • Double-check topic-verticals endpoint to see if preview-related code exists and needs to be removed.
@getdave
Copy link
Contributor

getdave commented Aug 12, 2019

Just noting here that if Templates are not created with an accessible description then the previews are not accessible. Adding a meta field to the Pages on the master site would allow Template authors to describe the Template which would allow us to add a text-based description of the Template in the Template selector UI.

@obenland obenland removed this from the Ajax: Iteration 8 milestone Sep 5, 2019
@obenland
Copy link
Member Author

obenland commented Oct 1, 2019

It turns out we'll need preview images a while longer. Closing until the day that we don't.

@obenland obenland closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants