Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendly: Change buttons to a standard link for AMP requests #15498

Closed
Copons opened this issue Apr 20, 2020 · 3 comments
Closed

Calendly: Change buttons to a standard link for AMP requests #15498

Copons opened this issue Apr 20, 2020 · 3 comments
Assignees
Labels
AMP [Block] Calendly [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Size] M [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@Copons
Copy link
Contributor

Copons commented Apr 20, 2020

Once the new Button inner block PR (#15370) is merged we need to use it in Calendly and update it to make it AMP compliant.

See the original PR (#14630 by @pablinos) for more info:

AMP strips out onClick handlers, so when the button version of
the block is rendered we should change it to a standard link to the Calendly
appointment page.

We could probably get around this by attaching the click handler in
another way, but it would still be good to treat an AMP request
differently.

@Copons Copons added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack AMP [Block] Calendly labels Apr 20, 2020
@Copons Copons self-assigned this Apr 20, 2020
@creativecoder creativecoder added [Type] Janitorial [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Type] Janitorial labels Apr 20, 2020
@Copons Copons assigned aaronrobertshaw and Copons and unassigned Copons May 26, 2020
@aaronrobertshaw
Copy link
Contributor

As part of #15863 the Calendly block will render the buttons as links. There is still a little work that needs doing for the AMP requests however. If the Calendly block sets any of the default color styles for the button they'll be missing on AMP views.

@Copons
Copy link
Contributor Author

Copons commented May 27, 2020

As part of #15863 the Calendly block will render the buttons as links. There is still a little work that needs doing for the AMP requests however. If the Calendly block sets any of the default color styles for the button they'll be missing on AMP views.

I think the color issue you are mentioning is the same as this one: #15697
I'm a little unsure on how to tackle it to be honest, but we can at least disregard it in the Calendly (and others) Button replacement PRs.

@Copons
Copy link
Contributor Author

Copons commented Jun 22, 2020

Fixed by #15863

@Copons Copons closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP [Block] Calendly [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Size] M [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

4 participants