Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timeout's TimeoutGenerator documentation #2275

Merged

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

#2266

Details on the issue fix or feature implementation

  • Fixed documentation comment
  • Enhanced timeout documentation
  • Added test case when TimeoutGenerator is null

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@peter-csala peter-csala changed the title Timeout's TimeoutGenerator documentation Fix Timeout's TimeoutGenerator documentation Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (1aece4e) to head (31c47b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         313      313           
  Lines        7444     7444           
  Branches     1122     1122           
=======================================
  Hits         6352     6352           
  Misses        746      746           
  Partials      346      346           
Flag Coverage Δ
linux 85.33% <ø> (ø)
macos 85.33% <ø> (ø)
windows 85.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit badf0df into App-vNext:main Aug 26, 2024
18 checks passed
@martincostello
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants