From 653f4d44ab85a51584b96889f1e10bc3476cf964 Mon Sep 17 00:00:00 2001 From: Lo Kim Date: Wed, 27 Sep 2023 13:03:40 -0400 Subject: [PATCH] [InlineError] Manually migrate `color` custom properties for v11 to v12 (#10714) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### WHY are these changes introduced? Resolves #10391. ### WHAT is this pull request doing? Manually migrates `InlineError` component `color` custom properties.
InlineError — before InlineError — before
InlineError — after InlineError — after
### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-uoggaugpto.chromatic.com/?path=/story/all-components-inlineerror--default) [Next branch storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-inlineerror--default) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --- polaris-react/src/components/InlineError/InlineError.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/polaris-react/src/components/InlineError/InlineError.scss b/polaris-react/src/components/InlineError/InlineError.scss index 136e296fe97..9250f8c18e2 100644 --- a/polaris-react/src/components/InlineError/InlineError.scss +++ b/polaris-react/src/components/InlineError/InlineError.scss @@ -3,11 +3,11 @@ .InlineError { display: flex; color: var(--p-color-text-critical); - fill: var(--p-color-icon-critical); + fill: var(--p-color-text-critical); } .Icon { - fill: var(--p-color-icon-critical); + fill: var(--p-color-text-critical); margin-left: calc(-1 * var(--p-space-050)); margin-right: var(--p-space-200);