Fixes for client non-persistence and blocking client.available() #259
Conversation
This fixes the broken rule of 3/5/0 in WiFiClient by removing the unneeded destructor, which caused the socket to stop prematurely on copy assignment. It also fixes the blocking behavior caused by `client.available()` by removing the unneeded `try_again` label and its corresponding `goto`. In its place, we stop the socket (already pending stop) instead. Closes Ameba-AIoT#257, Ameba-AIoT#258
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi, @M-ichae-l Apologies for the delayed reply. I wasn't available for the last couple of days, and I wanted to confirm the following with my equipment before I replied to your comment: Upon testing with my AMB82-Mini board, I was able to confirm that the proposed changes do not affect the operation of |
| @@ -95,14 +90,14 @@ int WiFiClient::available() | |||
| return 0; | |||
| } | |||
| if (_sock >= 0) { | |||
| try_again: | |||
There was a problem hiding this comment.
I would like to suggest to use _is_blocked by if condition, to keep both the update and original
| @@ -66,11 +66,6 @@ WiFiClient::WiFiClient(uint8_t sock, tProtMode portMode, tBlockingMode blockMode | |||
| _is_blocked = blockMode; | |||
| } | |||
|
|
|||
| WiFiClient::~WiFiClient() | |||
| { | |||
| stop(); | |||
There was a problem hiding this comment.
Is there any reason that remove this stop function?
There was a problem hiding this comment.
How about the following update
if (_is_blocked) {
stop();
}
There was a problem hiding this comment.
@redelacruz I think the suggested fix is ok. How about you?
revert: reinstates the try_again label and the relevant goto This reinstates the `try_again` label and the relevant `goto` statement as requested by @M-ichae-l in comment #r1713128977.
feat: stops socket if the client isn't in blocking mode When `WiFiClient::available()` is called, this stops the socket if `clientdrv.getLastErrno(_sock)` returns `EAGAIN` and the client isn't in blocking mode.
|
This pull request is stale because there is no activity for 14 days |
Description of Change
WiFiClientby removing the unneeded destructor, which caused the socket to stop prematurely on copy assignment.client.available()by removing the unneededtry_againlabel and its correspondinggoto. In its place, we stop the socket (already pending stop) instead.WiFiClientno longer has a destructor. This is congruent with Arduino's design for this API, as you must now callclient.stop()to close the connection (see [1], [2], [3]).Tests and Environments
Remark related links
Closes #257, closes #258