Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium unicode fallback mechanism broken for Win7 #16

Closed
Templayer opened this issue Oct 13, 2023 · 23 comments
Closed

Chromium unicode fallback mechanism broken for Win7 #16

Templayer opened this issue Oct 13, 2023 · 23 comments

Comments

@Templayer
Copy link

System Details

  • OS: Windows 7 64-bit Ultimate
  • Thorium Version - Any Chromium-based browser, really, but Thorium 109.0.5414.159 64-bit

Problem
It seems like Chromium and Chromium-based browsers have problems with Unicode fallback mechanisms under Win7. See screenshots for more details. I just noticed that some pages have invalid glyphs for buttons, etc. This isn't a Thorium issue per se, but a Chromium issue with Win7 (at least it appears to be at a first glance).

How to test: Look at glyphs on https://www.amp-what.com/unicode/search/cross while having big Unicode fonts installed.

Screenshots
Firefox for comparison (all glyphs accounted for):

image

Thorium:

image

Chromium (old version):

image

Fonts installed in the system:

Font List.docx

With fonts embedded into the docx file: UNFORTUNATELY, I CANNOT UPLOAD a 7z file due to retarded github limitations (not a supported file type!) and I had to store it in a zip file... goddamit!
Font List.zip

Both Noto Sans Symbols2 and Symbola have the missing glyph. Why is Chromium/Thorium not able to check these under Win7?

@JaegerFox
Copy link

that's because chromium uses the system font, firefox uses a built-in one

@Templayer
Copy link
Author

Templayer commented Nov 15, 2023

that's because chromium uses the system font, firefox uses a built-in one

That doesn't sound right - are you telling me that Chromium uses only ONE singular font from the system? Which one? There are a few fonts that are used in various parts of the system.

Doesn't sound right - there is no singular font that is capable of taking the entirety of Unicode. So that would be a serious design flaw if that was the case.

Also, Firefox is capable of using system fonts with a font fallback. I noticed that when I installed a slew if huge fonts - whereas Firefox showed invalid characters for Egyptian hieroglyphs, after installing those system fonts, Egyptian hieroglyphs would now show up (in a very pixelated way, but still).

@gz83
Copy link
Collaborator

gz83 commented Nov 15, 2023

Please report this issue to Google

@gz83 gz83 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2023
@Templayer
Copy link
Author

And if it is a Win7-specific problem?

@gz83
Copy link
Collaborator

gz83 commented Nov 15, 2023

And if it is a Win7-specific problem?

Try supermium and see if the problems you encountered still occur.

If supermium does not have this problem, then I will reopen this issue.

@Templayer

@JaegerFox
Copy link

JaegerFox commented Nov 16, 2023

Just do this test and you'll see, some sites like Twitter use a font that adds more compatibility with emojis or symbols.
but a correct way to compare is using this link
https://unicode.org/Public/emoji/11.0/emoji-test.txt
Chormium
Firefox

I dont have installed fonts in my system (Windows 8.1 which have more symbols than win7)

@Templayer
Copy link
Author

(Windows 8.1 which have more symbols than win7)

Nope, I can for example use and see more symbols (when used as a file name) in Win7... than Win10. I do have a modified Segoe UI Symbol and Segoe UI Emoji, among fallback and many big fonts. :)

Twitter

What's Twitter?

some sites

And have you tested the very site I made printscreens of? You should've checked... ;)

@JaegerFox
Copy link

If I put that link to you it is so that you could see first hand a real test of the unicode characters without any kind of coding. ok?
the page you show me are those that use fonts modified to show that kind of characters, you have ublock origin? deactivate the fonts and do a forced refresh (shift + ctrl + R) this page uses noto family fonts not segoe fonts
by deactivating fonts with ublock you will use entirely the characters of the system.

Firefox already have embedded fonts meanwhile Chromium replace Noto sans with another similar of your system

@Templayer
Copy link
Author

you have ublock origin

No.

@JaegerFox
Copy link

just one last proof that this is not a Thorium problem.
Captura
(left chromium vs right firefox disabled fonts using Ublock)

Captura2
(same but now with fonts enabled)

@Templayer
Copy link
Author

Yup, Supermium cannot show them either. Can somebody please place an Issue there and connect the Issues?

Thorium
image

Supermium
image

Firefox
image

@Templayer
Copy link
Author

@Alex313031

Just by the way, this is still an issue. Maybe the Supermium author could work on this, now that we have GDI font rendering back?

https://www.amp-what.com/unicode/search/rock

image

https://www.fontspace.com/unicode/char/1F66E-rightwards-rocket

I have both of these installed,...

image

...yet I do not see the symbols.

image

image

(The Install button is disabled because those are already installed...)

@Alex313031
Copy link
Owner

@JaegerFox @gz83 @Templayer Seems this isn't a Thorium specific problem, and y'all are also running modified Windows OSes. I cant devote time to this because there is already a backlog of work that needs to be done in both Thorium and Mercury. Sorry. If Supermium or upstream makes a fix for this, lemme know and I'll add it to the codebase.

@Alex313031 Alex313031 reopened this Jan 22, 2024
@Templayer
Copy link
Author

@JaegerFox @gz83 @Templayer Seems this isn't a Thorium specific problem, and y'all are also running modified Windows OSes. I cant devote time to this because there is already a backlog of work that needs to be done in both Thorium and Mercury. Sorry. If Supermium or upstream makes a fix for this, lemme know and I'll add it to the codebase.

Yup, I am (now) well aware that this Issue should be pushed upstream to Supermium, as was mentioned in the Issue thread by other people.

For now, I have removed the Adblock Plus filter for web fonts, because that didn't affect this Issue in any way, shape or form (the result is the same no matter if webfonts are enabled or disabled).

@Alex313031
Copy link
Owner

@Templayer Does it work OK with latest M122 and using the noto font pack?

@Templayer
Copy link
Author

@Templayer Does it work OK with latest M122 and using the noto font pack?

I had the Noto fonts installed when I made this issue way back.

Which was my point - the browser wasn't falling back to system fonts (like Noto) properly.

That was my entire point. Yet people were telling me that "Firefox has build in emojis and fonts".

image

image

Firefox loads Noto fonts fine. It can even show things like hieroglyphs through Noto.

Thorium:

image

Firefox (without using build-in stuff):

image

Firefox uses Noto Color Emoji from the system correctly:

samp {
  font-family: 'Noto Color Emoji', monospace;
}

Thorium shows that same font-family, but is unable to get the font from the operating system:

image

@Templayer
Copy link
Author

I'm starting to suspect that the only thing different is the way Firefox and Supermium enumerate system fonts.

I have weirdly INTERNALLY named font families for several fonts (containing nonstandard characters). Maybe that is why the enumeration fails and it never actually gets to Noto in the first place?

Could somebody check if Thorium/Supermium still gets all system fonts if the following fonts are installed in the system?

The "C.A.Gatingas" font was renamed internally by removing the dots, as the font was crashing several kinds of software, but I am going to pack it too (it's the entire reason why I thought of this problem in the first place). "Fanfarron" still has a diacritical symbol internally, while "a-e-i-o-u" has "_". "Metalona" seems to have "*". "hit-me-punk.01" has "," and "!" internally.

Nonstandardly internally named fonts.zip

I tried to specify "INTERNALLY" several times, as I am referring to the internal font name, not the filename or anything else.

@Alex313031
Copy link
Owner

Alex313031 commented May 12, 2024

@Templayer @JaegerFox This has been fixed in this commit > fdeb628#diff-02a23746537481b5b5e961197ae121bcdb6227527212aca8cc096f0433aa00f3

Next builds should have it fixed.

Same issue as #83

@Templayer
Copy link
Author

So I wasn't going crazy the entire time and it really is/was an issue.

Great! I was worried there for a sec, but the small pink elephant in the corner told me everything was going to be OK. YAY!

@Alex313031
Copy link
Owner

@Templayer Yeah, it was an issue even in M109, which is strange considering this had official Win7 support.

@Templayer
Copy link
Author

@Templayer Yeah, it was an issue even in M109, which is strange considering this had official Win7 support.

I'm still in 122 for Win7. When will the Thorium Legacy with this fix arrive so I can test if this was fixed or not?

@Alex313031
Copy link
Owner

@Templayer Building new releases for XP and 7 right now! This release is still based on M122, but has alot of fixes from win32ss, myself, and upstream, as well as backported features from regular M124 Thorium. Stay tuned!

@Templayer
Copy link
Author

@Templayer Building new releases for XP and 7 right now! This release is still based on M122, but has alot of fixes from win32ss, myself, and upstream, as well as backported features from regular M124 Thorium. Stay tuned!

Still occurs in the new version. Even with most of my extensions disabled (I had to reinstall them all).

image

image

I'm starting to suspect that the only thing different is the way Firefox and Supermium enumerate system fonts.

I have weirdly INTERNALLY named font families for several fonts (containing nonstandard characters). Maybe that is why the enumeration fails and it never actually gets to Noto in the first place?

Could somebody check if Thorium/Supermium still gets all system fonts if the following fonts are installed in the system?

The "C.A.Gatingas" font was renamed internally by removing the dots, as the font was crashing several kinds of software, but I am going to pack it too (it's the entire reason why I thought of this problem in the first place). "Fanfarron" still has a diacritical symbol internally, while "a-e-i-o-u" has "_". "Metalona" seems to have "*". "hit-me-punk.01" has "," and "!" internally.

Nonstandardly internally named fonts.zip

I tried to specify "INTERNALLY" several times, as I am referring to the internal font name, not the filename or anything else.

I still wonder about the font enumeration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants