Use peer dependency for Luxon

[Enngage]

Hey there!

Could you please make Luxon a Peer dependency? Since you have it listed as dependency it is shipped with your library and if the project is also using Luxon, it will result in code duplication and +60KB because multiple Luxon libraries can be included.

Using Peer dependencies will mitigate this problem completely.

[Agranom]

Hey

I had issue to make it as dependency. I'm afraid if I change it back there will be more issues )

[Enngage]

Thanks for a quick reply :-) I'm pretty sure there wouldn't be any issues (I've been using it for some time for several of my packages). It would be the same thing as Angular itself does with rxjs. What you would do is:

• Specify Luxon (ideally with minor relaxed versioning) as a dependency (e.g. "luxon": "^1.24.0")
• Move Luxon to devDependencies and peerDependencies in this repo as it is needed to build & run your code (moving it to devDependencies basically means it will install for you, but not for people using your library which is what you want to prevent your users from having duplicate Luxon libraries). There is pretty much no different for you if you install packages in your dependencies or devDependencies so it wouldn't break anything. It only affects what code is distributed alongside your code.
• Update your docs to include Luxon installation notes:

npm i --save ngx-material-timepicker
npm i --save luxon

Npm will tell people automatically to install peer dependencies when running npm i, but its good practice to include it in docs.

Btw: thank you for maintaining the library. We've tried probably all time selector for Angular and this one is the best we found.

[Enngage]

Adding a bundle report for reference.

[Agranom]

@Enngage Thanks for explanation. Definitely will do it soon.

[Enngage]

Any chance you can look at this? It should be really easy to implement - just move it to peerDependencies and it would save a lot of people at least 60KB from their bundles ;)

[Enngage]

Still nothing? This is an easy fix that takes about 1 minute to implement and saves 60KB for all users using your library in combination with luxon which is the best alternative for moment at this time...

[maxstee]

I'm also quite bothered by this.

I'm considering using date-fns to avoid that.

[Enngage]

There is probably no point in waiting anymore since fix that takes 1 minute to implement is here from last July. We are moving away from this library and instead created our own time picker. Gl anyways.

[edemircan]

Would be great. Could shrink my app with a few kb.

[Agranom]

Done. Pls update to the latest version. Sorry for being so long