Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] internationalization - ngx-material-timepicker #154

Closed
rajaramtt opened this issue Jun 10, 2019 · 10 comments
Closed

[Feature] internationalization - ngx-material-timepicker #154

rajaramtt opened this issue Jun 10, 2019 · 10 comments

Comments

@rajaramtt
Copy link

Please try to implement Internationalization and localization for ngx-material-timepicker.

@Agranom
Copy link
Owner

Agranom commented Jun 10, 2019

Yes. This will be the next feature

@paultobey
Copy link

Any idea on the schedule for internationalization support?

@Agranom
Copy link
Owner

Agranom commented Jul 28, 2019

I'll try to implement it during next two weeks. But I am not promise )

@Agranom
Copy link
Owner

Agranom commented Aug 15, 2019

It seems like there are 4 types of displaying time: Persian, Arabic, Chinese and standart. Am I right ?

@paultobey
Copy link

For time display, Persian looks like US to me, 'hh:mm:ss tt'. Of course AM/PM would be localized.

The same appears to be the case for most Arabic speaking countries, although some use slightly different formats.

China seems to use 'tt hh:mm:ss' for Simplified, 24-hour format for Traditional.

The .NET/Windows list of culture-based time formats is my only direct experience!

https://www.basicdatepicker.com/samples/cultureinfo.aspx

@Agranom Agranom added the in progress started implementation label Sep 2, 2019
@Agranom
Copy link
Owner

Agranom commented Sep 6, 2019

Guys, already implemented i18n, so you can test it on v5.0.0. See the doc how to set locale

@Agranom Agranom added in review awaiting feedback and removed in progress started implementation labels Sep 6, 2019
@paultobey
Copy link

I've grabbed the code but haven't had a chance to look at it yet. Is the intent that module.setLocale(loc) is the method of changing behavior? Is this dynamically adjustable (user changes her profile settings, for example, within the Angular app), without reloading?

@Agranom
Copy link
Owner

Agranom commented Sep 7, 2019

No, It's not dynamic. Is it better to make it dynamically ?

@paultobey
Copy link

For whatever reason, our customers expect to select the language and date/time settings "dynamically" (it makes QA easier, I think). That's not an indication that everyone's customers expect that, however. Just something for consideration.

@Agranom Agranom removed the in review awaiting feedback label Sep 11, 2019
@Agranom
Copy link
Owner

Agranom commented Sep 11, 2019

I'll leave it like static for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants