-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] internationalization - ngx-material-timepicker #154
Comments
Yes. This will be the next feature |
Any idea on the schedule for internationalization support? |
I'll try to implement it during next two weeks. But I am not promise ) |
It seems like there are 4 types of displaying time: Persian, Arabic, Chinese and standart. Am I right ? |
For time display, Persian looks like US to me, 'hh:mm:ss tt'. Of course AM/PM would be localized. The same appears to be the case for most Arabic speaking countries, although some use slightly different formats. China seems to use 'tt hh:mm:ss' for Simplified, 24-hour format for Traditional. The .NET/Windows list of culture-based time formats is my only direct experience! |
Guys, already implemented i18n, so you can test it on v5.0.0. See the doc how to set locale |
I've grabbed the code but haven't had a chance to look at it yet. Is the intent that module.setLocale(loc) is the method of changing behavior? Is this dynamically adjustable (user changes her profile settings, for example, within the Angular app), without reloading? |
No, It's not dynamic. Is it better to make it dynamically ? |
For whatever reason, our customers expect to select the language and date/time settings "dynamically" (it makes QA easier, I think). That's not an indication that everyone's customers expect that, however. Just something for consideration. |
I'll leave it like static for now. |
Please try to implement Internationalization and localization for ngx-material-timepicker.
The text was updated successfully, but these errors were encountered: