Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated cosmos-sdk 0.46 API usage #8803

Open
JimLarson opened this issue Jan 23, 2024 · 0 comments
Open

Clean up deprecated cosmos-sdk 0.46 API usage #8803

JimLarson opened this issue Jan 23, 2024 · 0 comments

Comments

@JimLarson
Copy link
Contributor

JimLarson commented Jan 23, 2024

What is the Problem Being Solved?

Cosmos-sdk has marked a number of the APIs we're using as "deprecated". See the 0.46 upgrade notes. While we're not forced to change the API usage until we do a cosmos-sdk upgrade to a version where the legacy compatibility is actually removed, doing so will exacerbate an already difficult migration process. We can break up the migration effort by cleaning up deprecated interfaces early.

Description of the Design

We want to make the following changes:

  • change sdk.Int and sdk.Uint to use their new location in the math package;
  • use x/errors instead of types/errors;
  • module-native parameter get/set instead of x/params. See the mint module's migration for example.
  • the x/gov module has a new v1 API;
  • our custom Coins min and max methods can be dropped in favor of the built-in version.

Security Considerations

N/A - these changes typically replace use of forwarding placeholders or identical implementations.

Scaling Considerations

N/A

Test Plan

N/A

Upgrade Considerations

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants