Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart wallets can get balances with zero transactions (for small # of users) #5356

Closed
Tracked by #5354
turadg opened this issue May 12, 2022 · 7 comments · Fixed by #5701
Closed
Tracked by #5354

Smart wallets can get balances with zero transactions (for small # of users) #5356

turadg opened this issue May 12, 2022 · 7 comments · Fixed by #5701
Assignees
Labels
enhancement New feature or request Epic read-no-tx topic: reading from the chain without a transaction wallet
Milestone

Comments

@turadg
Copy link
Member

turadg commented May 12, 2022

Epic milestone to #3995

Acceptance criteria

  • When using the wallet, Keplr is not brought up until there is a transfer of value
  • UI can show wallet balances
  • Subscriptions publish to Cosmos events
@turadg turadg added enhancement New feature or request Epic wallet and removed Epic labels May 12, 2022
@turadg
Copy link
Member Author

turadg commented May 12, 2022

@samsiegart what's a good ticket for "chain selection/signing frontend" ?

@dckc what's a good ticket for "Add cosmjs client to wallet dapp" ?

@gibson042 what's a good ticket for tracking that "backend subscriptions can reach frontend notifiers" ?

@samsiegart
Copy link
Contributor

@samsiegart what's a good ticket for "chain selection/signing frontend" ?

I think this was it #4421. That allows us to select the chain and get a cosmjs signer

@turadg
Copy link
Member Author

turadg commented May 12, 2022

@samsiegart cool. is there any other frontend work needed for this story? let's try to have it all as part of this epic

@dckc
Copy link
Member

dckc commented May 12, 2022

Acceptance criteria
Users can load wallet UI using on-chain wallet

I'm not sure I understand that. How can a user tell whether they're using the on-chain wallet or not?

I suspect an acceptance test will involve looking at the network traffic and / or block explorer to verify that we didn't add any cosmos transactions to get our balance. Another place to look might be the IST balance, since sending a swingset message costs (a little bit of) IST.

p.s. I was using #3756 to track pretty much the same thing. I wonder whether having two separate epics is cost-effective. I don't have much experience using epics, though. In my experience, enhancement (or bug) tickets with blockers is necessary and sufficient.

@samsiegart
Copy link
Contributor

I'm not sure I understand that. How can a user tell whether they're using the on-chain wallet or not?

They'll know when they connect to keplr in the wallet UI, or more concretely, if everything works and they don't have an ag-solo running.

@samsiegart
Copy link
Contributor

@samsiegart cool. is there any other frontend work needed for this story? let's try to have it all as part of this epic

Yes but I'm not sure what it looks like yet. We have to sign some sort of message to get the wallet bridge, all the purse balances, etc. in the UI.

@dckc
Copy link
Member

dckc commented May 12, 2022

@dckc what's a good ticket for "Add cosmjs client to wallet dapp" ?

#4398 and #4421 seem to cover it.

@dckc dckc added the read-no-tx topic: reading from the chain without a transaction label May 31, 2022
@dckc dckc self-assigned this May 31, 2022
@michaelfig michaelfig changed the title On-chain wallets can get balances with zero transactions (for small # of users) Smart wallets can get balances with zero transactions (for small # of users) Jun 3, 2022
@Tartuffo Tartuffo assigned michaelfig and unassigned dckc Jun 6, 2022
@turadg turadg closed this as completed Jun 29, 2022
@turadg turadg reopened this Jun 30, 2022
@mergify mergify bot closed this as completed in #5701 Jul 6, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic read-no-tx topic: reading from the chain without a transaction wallet
Projects
None yet
5 participants