Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fake Oracle for economic testing #5242

Closed
Tartuffo opened this issue Apr 28, 2022 · 2 comments · Fixed by #5374
Closed

Create fake Oracle for economic testing #5242

Tartuffo opened this issue Apr 28, 2022 · 2 comments · Fixed by #5374
Assignees
@dckc @dtribble
Labels
Inter-protocol Overarching Inter Protocol
Milestone
Mainnet 1 RC0

Comments

@Tartuffo
Copy link
Contributor

Tartuffo commented Apr 28, 2022 •
edited by dtribble
Loading

Problem to Solve

For economic stress test and other test deployments, we must enable directly specify the price, and have it propagated through.

Design

Clone ManualPriceAuthority and move the setPrice operation onto the creator facet rather than the priceAuthority. Note that ManualPriceAuthority` is made to simplify unit tests. Most code is reused from elsewhere, so I don't think it's worth trying to make a single notifier that covers both use cases.
@Tartuffo Tartuffo added the Inter-protocol Overarching Inter Protocol label Apr 28, 2022
@Tartuffo
Copy link
Contributor Author

Tartuffo commented May 4, 2022

@dtribble Please add detail.

@Tartuffo Tartuffo added this to the Mainnet 1 milestone May 5, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 milestone May 13, 2022
@michaelfig michaelfig mentioned this issue May 15, 2022
Merged
@Tartuffo Tartuffo added this to the Mainnet 1 milestone May 16, 2022
@mergify mergify bot closed this as completed in #5374 May 16, 2022
@dckc dckc mentioned this issue May 27, 2022
Closed
@dckc
Copy link
Member

dckc commented May 27, 2022 •
edited
Loading

To get the oracleAdmin:

To get a quote from it:

@dckc dckc mentioned this issue May 27, 2022
Closed
17 tasks
@dckc dckc mentioned this issue Jun 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

@dtribble dtribble

Labels
Inter-protocol Overarching Inter Protocol
Projects
None yet
Milestone
Mainnet 1 RC0
Development

Successfully merging a pull request may close this issue.

Bootstrap with oracle invitations Agoric/agoric-sdk
4 participants
@dckc @Tartuffo @dtribble @Chris-Hibbert