fix(xsnap): tolerate Symbols in console.log() arguments #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xsnap `print()` doesn't know how to print a Symbol, so until that's fixed, here's a workaround in our `tryPrint()` function. This is the backend of all console.log calls within the XS process. refs Moddable-OpenSource/moddable#679
warner
force-pushed
the
xsnap-print-symbols
branch
from
36485f9
to
4b8e7e3
Compare
dckc
approved these changes
Aug 7, 2021
| @@ -2,10 +2,14 @@ | |||
| function tryPrint(...args) { | |||
| try { | |||
| // eslint-disable-next-line | |||
| print(...args); | |||
| print(...args.map(arg => typeof arg === 'symbol' ? arg.toString() : arg)); | |||
There was a problem hiding this comment.
Interesting. The C code for print already does fprintf(stdout, "%s", xsToString(xsArg(i)));.
| send('ok'); | ||
| `); | ||
| await vat.close(); | ||
| t.deepEqual(['"ok"'], opts.messages); |
There was a problem hiding this comment.
This just seems to test that it doesn't throw. It wasn't throwing before, was it?
There was a problem hiding this comment.
Yeah, it throws without the .toString(). It seems that xsToString(foo) is different than foo.toString(): the former fails on Symbols, while the latter succeeds. I notice the same issue with quasiliteral stringification on both Node.js and XS: you can't template-stringify a Symbol, but you can .toString it.
There was a problem hiding this comment.
the try / catch in tryPrint didn't catch the exception???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xsnap
print()doesn't know how to print a Symbol, so until that'sfixed, here's a workaround in our
tryPrint()function. This is the backendof all console.log calls within the XS process.
refs Moddable-OpenSource/moddable#679