Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newly missing fars #3557

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix: newly missing fars #3557

merged 1 commit into from
Jul 29, 2021

Conversation

erights
Copy link
Member

@erights erights commented Jul 29, 2021

Y'all gotta declare all far objects, really.

@erights erights requested a review from FUDCo July 29, 2021 13:19
@erights erights self-assigned this Jul 29, 2021
@erights
Copy link
Member Author

erights commented Jul 29, 2021

@FUDCo please see the errors from #3525 , after rebasing on this one, which look like

 virtualObjects › representatives › virtual object gc

  test/virtualObjects/test-representatives.js:469

   468:   }                                                                     
   469:   t.deepEqual(remainingVOs, {                                           
   470:     'v1.vs.vom.o+1/2': '{"label":{"body":"\\"thing #2\\"","slots":[]}}',

  Difference:

    {
      'v1.vs.vom.o+1/2': '{"label":{"body":"\\"thing #2\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/2.refCount': '0 0',
      'v1.vs.vom.o+1/3': '{"label":{"body":"\\"thing #3\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/4': '{"label":{"body":"\\"thing #4\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/5': '{"label":{"body":"\\"thing #5\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/6': '{"label":{"body":"\\"thing #6\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/3.refCount': '1 0',
  +   'v1.vs.vom.o+1/8': '{"label":{"body":"\\"thing #8\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/9': '{"label":{"body":"\\"thing #9\\"","slots":[]}}',
    }

  › test/virtualObjects/test-representatives.js:469:5

  ─

  1 test failed
  12 known failures

Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but ergonomically this is very irritating. I'm thinking this could be moved one level higher, into the vat initialization code that calls buildRootObject.

@erights erights merged commit 32069cc into master Jul 29, 2021
@erights erights deleted the markm-newly-missing-fars branch July 29, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants