Settle REMOTE_STYLE name #2900
Merged
Settle REMOTE_STYLE name #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
added a commit
that referenced
this pull request
Apr 18, 2021
erights
force-pushed
the
markm-settle-remote-style-name
branch
from
4f99d72
to
3a83705
Compare
erights
force-pushed
the
markm-settle-remote-style-name
branch
from
3a83705
to
c389b87
Compare
erights
added a commit
that referenced
this pull request
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago, @michaelfig and I settled on terminology such that
'presence'is a name at the eventual-send/handled-promise layer of abstraction and'remotable'is a name at the marshal/passStyleOf level of abstraction. However, at that time, for remotables,passStyleOfwas already returning'presence'. To ease the transition from'presence'to'remotable'we introduced the constant nameREMOTE_STYLE.We recently revisited the naming at Agoric/documentation#456 (comment) . Although some of our other preferred name choices changed, this overriding one has remained stable. This PR changes the concrete
passStyleOfanswer for those cases from'presence'to'remotable'and also replaces all uses ofREMOTE_STYLEwith'remotable'. It deletes the constant nameREMOTE_STYLE.In addition, while doing these substitutions, I noticed that
coerceDisplayInfowas still trying to cope with a simple empty object being treated as a remotable, which is an irregularity we fixed long ago.As with #2898 there is a potential cross-version compat issue we need to think about before merging. However, this string shows up only in local APIs. It is never sent as part of a protocol and so is much less likely to cause any actual incompat issues.